Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): add lintFix to several other schematics #12938

Merged
merged 1 commit into from Dec 13, 2018
Merged

feat(@schematics/angular): add lintFix to several other schematics #12938

merged 1 commit into from Dec 13, 2018

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 12, 2018

At the moment some schematics contain this options for instance the guard, component etc.. But some others don't such as module

Fixes #12894 and Fixes #6272

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Nov 12, 2018
@filipesilva filipesilva requested review from hansl and clydin and removed request for filipesilva November 12, 2018 19:43
@filipesilva
Copy link
Contributor

@hansl @clydin can you take a look? Schematics is mostly under your wing.

@alan-agius4 alan-agius4 added needs: discussion On the agenda for team meeting to determine next steps and removed needs: discussion On the agenda for team meeting to determine next steps labels Dec 6, 2018
@angular angular deleted a comment from ngbot bot Dec 6, 2018
At the moment some schematics contain this options for instance the `guard`, `component` etc.. But some others don't such as `module`

Fixes #12894 and Fixes #6272
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be done at the cli level at some point so it doesn’t have to be inserted into every schematic. Especially since the actual linter is configurable at the cli level. Third party schematics also aren’t affected by this either.

@mgechev mgechev merged commit 0715beb into angular:master Dec 13, 2018
@alan-agius4 alan-agius4 deleted the feat_lint_fix branch December 14, 2018 08:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lintFix to all generate commands Add automatic style fixing for ng new and all generators.
5 participants