feat(@angular-devkit/build-angular): fine grain settings for sourceMaps #13062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
removed
the
target: patch
|
Still need to add a couple of tests but this is the idea. @clydin, @hansl, @filipesilva |
alan-agius4
requested review from
hansl,
clydin and
filipesilva
and removed request for
hansl and
clydin
clydin
reviewed
Nov 27, 2018
packages/angular_devkit/build_angular/src/angular-cli-files/models/build-options.ts
Outdated
Show resolved
Hide resolved
hansl
reviewed
Nov 27, 2018
packages/angular_devkit/build_angular/src/angular-cli-files/models/build-options.ts
Outdated
Show resolved
Hide resolved
filipesilva
approved these changes
Nov 29, 2018
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts
Show resolved
Hide resolved
| @@ -633,9 +633,48 @@ | |||
| "default": false | |||
| }, | |||
| "sourceMap": { | |||
| "type": "boolean", | |||
| "type": [ | |||
There was a problem hiding this comment.
Schema bookkeeping is getting pretty annoying. We should find a way around this sometime.
There was a problem hiding this comment.
Yeah, it’s pretty hard even just to add a new property. You have to add t in multiple places
clydin
reviewed
Nov 29, 2018
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts
Show resolved
Hide resolved
clydin
reviewed
Nov 29, 2018
clydin
reviewed
Nov 29, 2018
clydin
reviewed
Nov 29, 2018
This PR add more control over which sourceMaps you want, Now you can enable sourceMaps for scripts only, styles only or both. Also we added another functionality which are hidden sourcemaps. These are normaly used for error reporting tools. Fixes #7527
alan-agius4
added
the
target: major
This was referenced Jan 30, 2019
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 2, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add more control over which sourceMaps you want, Now you can enable sourceMaps for scripts only, styles only or both. Also we added another functionality which are hidden sourcemaps. These are normally used for error reporting tools.
Fixes #7527