Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular-devkit/build-angular): fix check for absolute paths in wi… #13868

Merged
merged 1 commit into from
Mar 11, 2019
Merged

fix(angular-devkit/build-angular): fix check for absolute paths in wi… #13868

merged 1 commit into from
Mar 11, 2019

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 11, 2019

…ndows in server config

This changes fixes Error: You must pass in a NgModule or NgModuleFactory to be bootstrapped.

At the moment the check for absolute path is not correct for windows.

Fixes #13865 and fixes angular/universal#1139

…indows in server config

This changes fixes `Error: You must pass in a NgModule or NgModuleFactory to be bootstrapped`.

At the moment the check for absolute path is not correct for windows.

Fixes #13865 and fixes angular/universal#1139
@vikerman vikerman merged commit 901042d into angular:master Mar 11, 2019
@alan-agius4 alan-agius4 deleted the webpack-server-ssr branch March 11, 2019 21:07
@chiraggmodi
Copy link

how to fix this?
I mean how can I update my cli to this version?

@alan-agius4
Copy link
Collaborator Author

You can use the snapshots as this is not yet released.

See here: https://github.com/angular/angular-devkit-build-angular-builds

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
5 participants