Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable existing aot i18n E2E test for ivy #15913

Closed
wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 22, 2019

This is blocked on a FW xliff 1.2 parser fix for optional target-language attribute support.

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 22, 2019
await replaceInFile(
`src/locale/messages.${lang}.xlf`,
'source-language="en-US"',
`source-language="en-US" target-language="${lang}"`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target-language was not needed in VE but seems to be required on Ivy.

@clydin looked into this and it seems like the xliff 1.2 parser lists it as optional in http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html.

But @angular/localize will throw if it's not there: https://github.com/angular/angular/blob/ec482dadb19eea5cd247eb7428a5d88640bd38f8/packages/localize/src/tools/src/translate/translation_files/translation_parsers/xliff1/xliff1_translation_parser.ts#L56

@petebacondarwin can you shed some light on this? Is this intended, and if so, is there documentation telling users they must do it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it's a bug, opened as angular/angular#33323

@petebacondarwin
Copy link
Member

PR to unblock this: angular/angular#33381

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 4, 2019
@clydin clydin deleted the ivy-e2e-aot branch January 9, 2020 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
state: blocked target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants