-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular-devkit/build-angular): correctly extract messages when using cached build #22266
Conversation
…sing cached build Extracted messages are not part of Webpack pipeline and hence they cannot be retrieved from cache. Therefore, we need to mark the extraction loader as non cacheable. Closes #22264
packages/angular_devkit/build_angular/src/builders/extract-i18n/ivy-extract-loader.ts
Outdated
Show resolved
Hide resolved
@@ -21,6 +21,11 @@ export default function localizeExtractLoader( | |||
content: string, | |||
map: LoaderSourceMap, | |||
) { | |||
// This loader is not cacheable due to message extraction works. | |||
// Extracted messages are not part of webpack pipeline and hence they cannot be retrieved from cache. | |||
// TODO: We should investigate in the future on making this deterministic and more cacheable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we file an issue or project about this? I'm always hesitant about TODO
's in the code which tend to be forgotten about. Issues are more easily triaged, assignable, and actionable IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
… when using cached build
…sing cached build (#22266) * fix(@angular-devkit/build-angular): correctly extract messages when using cached build Extracted messages are not part of Webpack pipeline and hence they cannot be retrieved from cache. Therefore, we need to mark the extraction loader as non cacheable. Closes #22264 * fixup! fix(@angular-devkit/build-angular): correctly extract messages when using cached build (cherry picked from commit 52c6c3d)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Extracted messages are not part of Webpack pipeline and hence they cannot be retrieved from cache. Therefore, we need to mark the extraction loader as non cacheable.
Closes #22264