Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): remove workaround for fidelity and performance of babel sourcemaps #22646

Merged
merged 1 commit into from Feb 7, 2022

Conversation

alan-agius4
Copy link
Collaborator

With this change we remove the workaround for fidelity and performance of babel sourcemaps as this is no longer needed as Babel now uses @ampproject/remapping to merge sourcemaps.

See babel/babel#14209 for more context.

…ty and performance of babel sourcemaps

With this change we remove the workaround for fidelity and performance of babel sourcemaps as this is no longer needed as Babel now uses `@ampproject/remapping` to merge sourcemaps.

See babel/babel#14209 for more context.
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Feb 4, 2022
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 4, 2022
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Glad to see this optimization got upstreamed.

@filipesilva filipesilva merged commit 7c92bec into angular:master Feb 7, 2022
@alan-agius4 alan-agius4 deleted the babel-result-remap branch February 7, 2022 11:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants