Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add initial Github Action lint workflow #25247

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented May 19, 2023

The eslint CI action has now been moved to a Github Action.
The check also now adds annotations to the PR code when eslint generates an error
or warning. Additionally, the eslint cache is saved and reused which provides improved
runtimes for the CI action.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 19, 2023
@clydin clydin force-pushed the ci/lint-action branch 12 times, most recently from d414e71 to 17d4839 Compare May 19, 2023 17:55
The eslint CI action has now been moved to a Github Action.
The check also now adds annotations to PRs when eslint generates an error
or warning. The eslint cache is now saved and reused which provides improved
runtimes for the CI action.
@clydin clydin removed the state: WIP label May 19, 2023
@clydin clydin marked this pull request as ready for review May 19, 2023 18:04
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 19, 2023
@clydin clydin requested a review from alan-agius4 May 22, 2023 13:04
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2023
@clydin clydin merged commit c349b4c into angular:main May 22, 2023
24 checks passed
@clydin clydin deleted the ci/lint-action branch May 22, 2023 15:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants