Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(@angular/build): improve rebuild time for file loader usage with prebundling #27642

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented May 14, 2024

Rebuilds can now use the optimized external package execute path when using the application builder's loader option if only file type loaders are used. The Vite-based development server will now process any file type loader usage for third-party file references which removes the need for the build itself to handle the loader processing. This change only optimizes the case where only the file loader type is used. If any other loader types are present, the optimized execution path will not be used. Future further improvements may allow for all cases to use the optimized rebuild execution path.

… prebundling

Rebuilds can now use the optimized external package execute path when using
the `application` builder's `loader` option if only `file` type loaders are
used. The Vite-based development server will now process any `file` type
loader usage for third-party file references which removes the need for the
build itself to handle the loader processing. This change only optimizes
the case where only the `file` loader type is used. If any other loader types
are present, the optimized execution path will not be used. Future further
improvements may allow for all cases to use the optimized rebuild execution
path.
@clydin clydin added target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer labels May 14, 2024
@clydin clydin requested a review from alan-agius4 May 14, 2024 18:35
@clydin clydin marked this pull request as ready for review May 14, 2024 18:35
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 15, 2024
@clydin clydin merged commit bc47fa1 into angular:main May 15, 2024
36 checks passed
@clydin clydin deleted the application/optimize-rebuild-file-loader branch May 15, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants