fix(@angular/cli): disable node global #8130

filipesilva · 2017-10-20T15:59:38Z

The node only global object had been left in because it used to cause a build size regression with Angular.

This doesn't seem to be the case anymore so it should be removed because it causes problematic interactions with some libraries.

Fix #5804
Supersedes #7931

filipesilva · 2017-10-20T20:21:51Z

Note: webpack-dev-server@3.8.0 and up do not support old IE versions: https://github.com/webpack/webpack-dev-server#caveats

This will be fixed in CLI once angular/angular-cli#8130 lands. -rw-r--r-- 1 iminar eng 14942 Oct 20 22:23 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 20 22:23 dist/inline.5d66b81ec9e01af9d28d.bundle.js -rw-r--r-- 1 iminar eng 528395 Oct 20 22:23 dist/main.e36bb99245ca52ae546f.bundle.js -rw-r--r-- 1 iminar eng 37205 Oct 20 22:23 dist/polyfills.0dfca732c5a075c110d0.bundle.js

Wykks · 2017-10-21T18:40:53Z

Whoops I found an issue with these changes :
Uncaught ReferenceError: process is not defined
https://github.com/mapbox/mapbox-sdk-js/blob/f1012d33d5315866a66bf97d27d0dc0f66807161/vendor/invariant.js#L23
Only with ng serve, prod serve works fine.

filipesilva · 2017-10-21T19:52:40Z

Ok I see. It's quite common for libs to try and check the env if available so we shouldn't disable it.

Thanks a bunch for testing this, it would have gotten through otherwise.

The node only `global` object had been left in because it used to cause a build size regression with Angular. This doesn't seem to be the case anymore so it should be removed because it causes problematic interactions with some libraries. Fix angular#5804 Supersedes angular#7931

filipesilva · 2017-10-22T13:56:59Z

@Wykks done, the PR doesn't remove process anymore.

IgorMinar

I confirmed that this helps quite a bit for aio. I'm not sure what all the implications are for other projects.

This will be fixed in CLI once angular/angular-cli#8130 lands. -rw-r--r-- 1 iminar eng 14942 Oct 20 22:23 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 20 22:23 dist/inline.5d66b81ec9e01af9d28d.bundle.js -rw-r--r-- 1 iminar eng 528395 Oct 20 22:23 dist/main.e36bb99245ca52ae546f.bundle.js -rw-r--r-- 1 iminar eng 37205 Oct 20 22:23 dist/polyfills.0dfca732c5a075c110d0.bundle.js

IgorMinar · 2017-10-24T09:40:26Z

heads up that this might break the old service worker library. see: angular/angular#19702 (comment) should we make this option configurable? or at least turn it on if the old service worker is present?

…

On Mon, Oct 23, 2017 at 2:57 PM Hans ***@***.***> wrote: Merged #8130 <#8130>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8130 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6KeQsmmPFnlPoo7g0jps2eLV1Xbsks5svQvmgaJpZM4QA4EL> .

filipesilva · 2017-10-24T09:56:35Z

@IgorMinar I think the error on the message you linked was due to patching the CLI files to disable global but not having updated webpack-dev-server with it (as this PR does). The webpack-dev-server version was needed to fix webpack/webpack-dev-server#1147 (fixed by webpack/webpack-dev-server#1148).

This will be fixed in CLI once angular/angular-cli#8130 lands. -rw-r--r-- 1 iminar eng 14942 Oct 20 22:23 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 20 22:23 dist/inline.5d66b81ec9e01af9d28d.bundle.js -rw-r--r-- 1 iminar eng 528395 Oct 20 22:23 dist/main.e36bb99245ca52ae546f.bundle.js -rw-r--r-- 1 iminar eng 37205 Oct 20 22:23 dist/polyfills.0dfca732c5a075c110d0.bundle.js

hccampos · 2017-10-24T11:57:18Z

Seems like pdfjs is broken due to this change. It (or one of its dependencies) tries to load the browserify Buffer, which checks the environment.

vecernik · 2017-10-27T13:27:37Z

can you make global configurable in angular-cli.json ? It also breaks Faye.

IgorMinar · 2017-10-27T13:41:55Z

I'm starting to think that this will have to be configurable to allow certain libraries to work, but it should be off by default.

…

On Fri, Oct 27, 2017 at 3:27 PM Michal Žeravík ***@***.***> wrote: can you make global configurable in angular-cli.json ? It also breaks Faye. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8130 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6J4x0OVZw9KAZ4q3mOuJEh6ewCv7ks5swdpLgaJpZM4QA4EL> .

vecernik · 2017-10-27T13:56:48Z

@IgorMinar I agree. I have found no way how to get Faye (and possibly others) to work without global.

This will be fixed in CLI once angular/angular-cli#8130 lands. -rw-r--r-- 1 iminar eng 14942 Oct 20 22:23 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 20 22:23 dist/inline.5d66b81ec9e01af9d28d.bundle.js -rw-r--r-- 1 iminar eng 528395 Oct 20 22:23 dist/main.e36bb99245ca52ae546f.bundle.js -rw-r--r-- 1 iminar eng 37205 Oct 20 22:23 dist/polyfills.0dfca732c5a075c110d0.bundle.js

This will be fixed in CLI once angular/angular-cli#8130 lands. -rw-r--r-- 1 iminar eng 14942 Oct 20 22:23 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 20 22:23 dist/inline.5d66b81ec9e01af9d28d.bundle.js -rw-r--r-- 1 iminar eng 528395 Oct 20 22:23 dist/main.e36bb99245ca52ae546f.bundle.js -rw-r--r-- 1 iminar eng 37205 Oct 20 22:23 dist/polyfills.0dfca732c5a075c110d0.bundle.js PR Close #19702

angular-automatic-lock-bot · 2019-09-12T05:41:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 20, 2017

filipesilva requested a review from hansl October 20, 2017 15:59

filipesilva assigned hansl Oct 20, 2017

filipesilva force-pushed the disable-global branch from 47fbbb8 to 5cdcc36 Compare October 20, 2017 20:20

filipesilva force-pushed the disable-global branch from 5cdcc36 to fbc78b4 Compare October 20, 2017 21:56

Wykks mentioned this pull request Oct 21, 2017

mapboxgl is incompatible with the CLI in a production build #5804

Closed

filipesilva force-pushed the disable-global branch from fbc78b4 to 3d5f163 Compare October 22, 2017 13:56

IgorMinar reviewed Oct 23, 2017

View reviewed changes

fix(@angular/cli): update uglifyjs-webpack-plugin to 1.0.0

9f2958a

hansl approved these changes Oct 23, 2017

View reviewed changes

hansl merged commit a167a33 into angular:master Oct 23, 2017

filipesilva deleted the disable-global branch October 23, 2017 22:10

filipesilva mentioned this pull request Oct 31, 2017

fix(@angular/cli): Reenable node global #8250

Merged

filipesilva mentioned this pull request Mar 1, 2018

Can't resolve 'net'/'global' or other node globals #9827

Closed

angular-automatic-lock-bot bot unassigned hansl Sep 12, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(@angular/cli): disable node global #8130

fix(@angular/cli): disable node global #8130

filipesilva commented Oct 20, 2017

filipesilva commented Oct 20, 2017

Wykks commented Oct 21, 2017 •

edited

filipesilva commented Oct 21, 2017

filipesilva commented Oct 22, 2017

IgorMinar left a comment

IgorMinar commented Oct 24, 2017 via email

filipesilva commented Oct 24, 2017

hccampos commented Oct 24, 2017

vecernik commented Oct 27, 2017

IgorMinar commented Oct 27, 2017 via email

vecernik commented Oct 27, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

fix(@angular/cli): disable node global #8130

fix(@angular/cli): disable node global #8130

Conversation

filipesilva commented Oct 20, 2017

filipesilva commented Oct 20, 2017

Wykks commented Oct 21, 2017 • edited

filipesilva commented Oct 21, 2017

filipesilva commented Oct 22, 2017

IgorMinar left a comment

Choose a reason for hiding this comment

IgorMinar commented Oct 24, 2017 via email

filipesilva commented Oct 24, 2017

hccampos commented Oct 24, 2017

vecernik commented Oct 27, 2017

IgorMinar commented Oct 27, 2017 via email

vecernik commented Oct 27, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

Wykks commented Oct 21, 2017 •

edited