fix(compiler-cli): accept nullish coalescing operator for any and unk…

…nown types (#44862) We should not make assumptions about the any and unknown types; using a nullish coalescing operator is acceptable for those. PR Close #44862
angular · Jan 31, 2022 · 0778e6f · 0778e6f
1 parent 25f8305
commit 0778e6f
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/...compiler-cli/src/ngtsc/typecheck/extended/checks/nullish_coalescing_not_nullable/index.ts b/...compiler-cli/src/ngtsc/typecheck/extended/checks/nullish_coalescing_not_nullable/index.ts
@@ -35,6 +35,12 @@ class NullishCoalescingNotNullableCheck extends
       return [];
     }
     const typeLeft = symbolLeft.tsType;
+    if (typeLeft.flags & (ts.TypeFlags.Any | ts.TypeFlags.Unknown)) {
+      // We should not make assumptions about the any and unknown types; using a nullish coalescing
+      // operator is acceptable for those.
+      return [];
+    }
+
     // If the left operand's type is different from its non-nullable self, then it must
     // contain a null or undefined so this nullish coalescing operator is useful. No diagnostic to
     // report.

diff --git a/...ended/test/checks/nullish_coalescing_not_nullable/nullish_coalescing_not_nullable_spec.ts b/...ended/test/checks/nullish_coalescing_not_nullable/nullish_coalescing_not_nullable_spec.ts
@@ -74,6 +74,42 @@ runInEachFileSystem(() => {
       expect(diags.length).toBe(0);
     });
 
+    it('should not produce nullish coalescing warning for the any type', () => {
+      const fileName = absoluteFrom('/main.ts');
+      const {program, templateTypeChecker} = setup([{
+        fileName,
+        templates: {
+          'TestCmp': `{{ var1 ?? 'foo' }}`,
+        },
+        source: 'export class TestCmp { var1: any; }'
+      }]);
+      const sf = getSourceFileOrError(program, fileName);
+      const component = getClass(sf, 'TestCmp');
+      const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
+          templateTypeChecker, program.getTypeChecker(), [nullishCoalescingNotNullableFactory],
+          {} /* options */);
+      const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
+      expect(diags.length).toBe(0);
+    });
+
+    it('should not produce nullish coalescing warning for the unknown type', () => {
+      const fileName = absoluteFrom('/main.ts');
+      const {program, templateTypeChecker} = setup([{
+        fileName,
+        templates: {
+          'TestCmp': `{{ var1 ?? 'foo' }}`,
+        },
+        source: 'export class TestCmp { var1: unknown; }'
+      }]);
+      const sf = getSourceFileOrError(program, fileName);
+      const component = getClass(sf, 'TestCmp');
+      const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
+          templateTypeChecker, program.getTypeChecker(), [nullishCoalescingNotNullableFactory],
+          {} /* options */);
+      const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
+      expect(diags.length).toBe(0);
+    });
+
     it('should not produce nullish coalescing warning for a type that includes undefined', () => {
       const fileName = absoluteFrom('/main.ts');
       const {program, templateTypeChecker} = setup([{
@@ -165,7 +201,7 @@ runInEachFileSystem(() => {
              },
              source: `
                export class TestCmp {
-                 func: (): string | null => null;
+                 func = (): string | null => null;
                }
              `,
            },