Skip to content

Commit

Permalink
feat(core): add support for Node.js version 18 (#47730)
Browse files Browse the repository at this point in the history 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.

PR Close #47730
  • Loading branch information
@alan-agius4 @thePunderWoman
alan-agius4 authored and thePunderWoman committed Oct 11, 2022
1 parent b618b5a commit 1b9fd46
Show file tree
Hide file tree
Showing 20 changed files with 24 additions and 24 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Expand Up @@ -92,7 +92,7 @@ executors:
type: string
default: medium
docker:
- image: cimg/node:16.10.0
- image: cimg/node:16.13.0
resource_class: << parameters.resource_class >>
working_directory: ~/ng

Expand All @@ -102,7 +102,7 @@ executors:
type: string
default: medium
docker:
- image: cimg/node:16.10.0-browsers
- image: cimg/node:16.13.0-browsers
resource_class: << parameters.resource_class >>
working_directory: ~/ng

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
@@ -1 +1 @@
16.10.0
16.13.0
2 changes: 1 addition & 1 deletion WORKSPACE
View file
Expand Up @@ -56,7 +56,7 @@ load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")

nodejs_register_toolchains(
name = "nodejs",
node_version = "16.10.0",
node_version = "16.13.0",
)

# Download npm dependencies.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Expand Up @@ -8,7 +8,7 @@
"license": "MIT",
"//engines-comment": "Keep this in sync with /aio/package.json and /aio/tools/examples/shared/package.json",
"engines": {
"node": "^14.15.0 || >=16.10.0",
"node": "^14.20.0 || ^16.13.0 || >=18.10.0",
"yarn": ">=1.22.4 <2",
"npm": "Please use yarn instead of NPM to install dependencies"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/animations/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bazel/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"bin": {
"ngc-wrapped": "./src/ngc-wrapped/index.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/common/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"locales": "locales",
"dependencies": {
Expand Down Expand Up @@ -35,4 +35,4 @@
"**/global/*.js",
"**/closure-locale.*"
]
}
}
2 changes: 1 addition & 1 deletion packages/compiler-cli/package.json
View file
Expand Up @@ -79,7 +79,7 @@
],
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"bugs": {
"url": "https://github.com/angular/angular/issues"
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/core/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"exports": {
"./schematics/*": {
Expand All @@ -29,4 +29,4 @@
"packageGroup": "NG_UPDATE_PACKAGE_GROUP"
},
"sideEffects": false
}
}
2 changes: 1 addition & 1 deletion packages/elements/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/forms/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand All @@ -25,4 +25,4 @@
"packageGroup": "NG_UPDATE_PACKAGE_GROUP"
},
"sideEffects": false
}
}
2 changes: 1 addition & 1 deletion packages/language-service/package.json
View file
Expand Up @@ -7,7 +7,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/localize/package.json
View file
Expand Up @@ -16,7 +16,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/platform-browser-dynamic/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/platform-browser/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/platform-server/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"peerDependencies": {
"@angular/animations": "0.0.0-PLACEHOLDER",
Expand Down
2 changes: 1 addition & 1 deletion packages/router/package.json
View file
Expand Up @@ -14,7 +14,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"bugs": {
"url": "https://github.com/angular/angular/issues"
Expand Down
2 changes: 1 addition & 1 deletion packages/service-worker/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"exports": {
"./ngsw-worker.js": {
Expand Down
2 changes: 1 addition & 1 deletion packages/upgrade/package.json
View file
Expand Up @@ -5,7 +5,7 @@
"author": "angular",
"license": "MIT",
"engines": {
"node": "^14.15.0 || >=16.10.0"
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down

4 comments on commit 1b9fd46

@backflip
Copy link

@backflip backflip commented on 1b9fd46 Mar 13, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4, quick question: The docs say 18.10.x while the version specification allows >=18.10.0 (which would include major versions like 19, too, unless I'm mistaken). Is there a reason for this difference?

@alan-agius4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4, quick question: The docs say 18.10.x while the version specification allows >=18.10.0 (which would include major versions like 19, too, unless I'm mistaken). Is there a reason for this difference?

We do allow usage of version 19+, but these versions are not officially supported.

@backflip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4, thanks a lot! Do you test any 18.x version apart from 18.10.0?

@alan-agius4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! Do you test any 18.x version apart from 18.10.0?

No, we only test the lowest supported versions as this ensures that we do not use APIs which are only present in newer Node.js v18 releases.

Please sign in to comment.