Skip to content

Commit

Permalink
refactor(bazel): add missing comment about JS providers to ng_module.…
Browse files Browse the repository at this point in the history
…bzl (#33332)

PR Close #33332
  • Loading branch information
gregmagolan authored and AndrewKushnir committed Oct 24, 2019
1 parent f76b370 commit 25ed82d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/bazel/src/ng_module.bzl
Expand Up @@ -619,6 +619,8 @@ def _ng_module_impl(ctx):
ts_providers = ng_module_impl(ctx, compile_ts)

# Add in new JS providers
# See design doc https://docs.google.com/document/d/1ggkY5RqUkVL4aQLYm7esRW978LgX3GUCnQirrk5E1C0/edit#
# and issue https://github.com/bazelbuild/rules_nodejs/issues/57 for more details.
ts_providers["providers"].extend([
js_named_module_info(
sources = ts_providers["typescript"]["es5_sources"],
Expand All @@ -628,6 +630,9 @@ def _ng_module_impl(ctx):
sources = ts_providers["typescript"]["es6_sources"],
deps = ctx.attr.deps,
),
# TODO: Add remaining shared JS providers from design doc
# (JSModuleInfo) and remove legacy "typescript" provider
# once it is no longer needed.
])

return ts_providers_dict_to_struct(ts_providers)
Expand Down

0 comments on commit 25ed82d

Please sign in to comment.