Skip to content

Commit

Permalink
feat(core): support TypeScript 4.8 (#47038)
Browse files Browse the repository at this point in the history
Adds support for TypeScript 4.8 and resolves some issues that came up as a result of the update.

Most of the issues came from some changes in TypeScript where the `decorators` and `modifiers` properties were removed from most node types, and were combined into a single `modifiers` array. Since we need to continue supporting TS 4.6 and 4.7 until v15, I ended up creating a new `ngtsc/ts_compatibility` directory to make it easier to reuse the new backwards-compatible code.

PR Close #47038
  • Loading branch information
crisbeto authored and Pawel Kozlowski committed Aug 16, 2022
1 parent 75df404 commit 31429ea
Show file tree
Hide file tree
Showing 97 changed files with 30,177 additions and 23,782 deletions.
2 changes: 2 additions & 0 deletions .bazelignore
Expand Up @@ -18,6 +18,7 @@ integration/cli-hello-world-ivy-compat/node_modules
integration/cli-hello-world-ivy-i18n/node_modules
integration/cli-hello-world-ivy-minimal/node_modules
integration/cli-hello-world-lazy/node_modules
integration/cli-hello-world-ts-47/node_modules
integration/dynamic-compiler/node_modules
integration/hello_world__closure/node_modules
integration/hello_world__systemjs_umd/node_modules
Expand Down Expand Up @@ -47,6 +48,7 @@ integration/cli-hello-world-ivy-compat/.yarn_local_cache
integration/cli-hello-world-ivy-i18n/.yarn_local_cache
integration/cli-hello-world-ivy-minimal/.yarn_local_cache
integration/cli-hello-world-lazy/.yarn_local_cache
integration/cli-hello-world-ts-47/.yarn_local_cache
integration/dynamic-compiler/.yarn_local_cache
integration/hello_world__closure/.yarn_local_cache
integration/hello_world__systemjs_umd/.yarn_local_cache
Expand Down
2 changes: 2 additions & 0 deletions integration/animations/BUILD.bazel
Expand Up @@ -2,6 +2,8 @@ load("//integration:index.bzl", "ng_integration_test")

ng_integration_test(
name = "test",
# Pinned temporarily until the CLI is updated to support TS 4.8.
pinned_npm_packages = ["typescript"],
setup_chromium = True,
track_payload_size = "animations",
)
2 changes: 1 addition & 1 deletion integration/animations/package.json
Expand Up @@ -42,6 +42,6 @@
"protractor": "file:../../node_modules/protractor",
"ts-node": "8.3.0",
"tslint": "5.18.0",
"typescript": "file:../../node_modules/typescript"
"typescript": "~4.7.2"
}
}

0 comments on commit 31429ea

Please sign in to comment.