perf(ivy): avoid repeated tNode.initialInputs reads (#33322)

PR Close #33322
angular · Oct 31, 2019 · 4452d6d · 4452d6d
1 parent 41caafc
commit 4452d6d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts
@@ -1103,6 +1103,7 @@ function instantiateAllDirectives(
 
   attachPatchData(native, lView);
 
+  const initialInputs = tNode.initialInputs;
   for (let i = start; i < end; i++) {
     const def = tView.data[i] as DirectiveDef<any>;
     const isComponent = isComponentDef(def);
@@ -1115,8 +1116,8 @@ function instantiateAllDirectives(
     const directive = getNodeInjectable(tView.data, lView, i, tNode);
     attachPatchData(directive, lView);
 
-    if (tNode.initialInputs !== null) {
-      setInputsFromAttrs(lView, i - start, directive, def, tNode);
+    if (initialInputs !== null) {
+      setInputsFromAttrs(lView, i - start, directive, def, tNode, initialInputs !);
     }
 
     if (isComponent) {
@@ -1348,8 +1349,8 @@ export function elementAttributeInternal(
  * @param tNode The static data for this node
  */
 function setInputsFromAttrs<T>(
-    lView: LView, directiveIndex: number, instance: T, def: DirectiveDef<T>, tNode: TNode): void {
-  const initialInputData = tNode.initialInputs as InitialInputData;
+    lView: LView, directiveIndex: number, instance: T, def: DirectiveDef<T>, tNode: TNode,
+    initialInputData: InitialInputData): void {
   const initialInputs: InitialInputs|null = initialInputData ![directiveIndex];
   if (initialInputs !== null) {
     const setInput = def.setInput;

diff --git a/packages/core/src/render3/interfaces/node.ts b/packages/core/src/render3/interfaces/node.ts
@@ -603,7 +603,7 @@ export interface TProjectionNode extends TNode {
 }
 
 /**
- * An union type representing all TNode types that can host a directive.
+ * A union type representing all TNode types that can host a directive.
  */
 export type TDirectiveHostNode = TElementNode | TContainerNode | TElementContainerNode;
 

diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@@ -533,12 +533,6 @@
   {
     "name": "objectToClassName"
   },
-  {
-    "name": "postProcessBaseDirective"
-  },
-  {
-    "name": "postProcessDirective"
-  },
   {
     "name": "refreshChildComponents"
   },