Skip to content

Commit

Permalink
docs(common): Remove async pipe from ngFor example (#33378)
Browse files Browse the repository at this point in the history
Using the async pipe as the very first example makes it very confusing for beginners. Most people believe that | async is required for ngFor. I would remove that part to make the example solely focused on NgFor.
PR Close #33378
  • Loading branch information
alcfeoh authored and atscott committed Oct 31, 2019
1 parent 602eeee commit 4d4b527
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/common/src/directives/ng_for_of.ts
Expand Up @@ -75,7 +75,7 @@ export class NgForOfContext<T> {
* For example:
*
* ```
* <li *ngFor="let user of userObservable | async as users; index as i; first as isFirst">
* <li *ngFor="let user of users; index as i; first as isFirst">
* {{i}}/{{users.length}}. {{user}} <span *ngIf="isFirst">default</span>
* </li>
* ```
Expand Down

0 comments on commit 4d4b527

Please sign in to comment.