build: remove Windows CI check (#52140) (#55527)

Based on recent discussions, these changes remove the Windows CI check because it has been too flaky for too long. Furthermore, we've concluded that the simulated file system in the compiler tests already catches the same set of bugs as running the tests on a real Windows system.

PR Close #52140

(cherry picked from commit 5a969e0)

PR Close #55527

.github/workflows/ci.yml

@@ -74,22 +74,6 @@ jobs:
       - name: Test build
         run: yarn devtools:build:chrome
 
-  framework-win:
-    runs-on: windows-latest
-    steps:
-      - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@0109d498b0f6aae418ed4924a5e5c65695f0ac61
-        with:
-          cache-node-modules: true
-      - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@0109d498b0f6aae418ed4924a5e5c65695f0ac61
-      - name: Setup Bazel Remote Caching
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@0109d498b0f6aae418ed4924a5e5c65695f0ac61
-      - name: Install node modules
-        run: yarn install --frozen-lockfile --network-timeout 100000
-      - name: Test all windows CI targets
-        run: bazel test --test_tag_filters="-browser:chromium-local" //packages/compiler-cli/...
-
   test:
     runs-on: ubuntu-latest-4core
     steps:

packages/compiler-cli/src/ngtsc/file_system/testing/src/test_helper.ts

@@ -39,17 +39,7 @@ const FS_WINDOWS = 'Windows';
 const FS_ALL = [FS_OS_X, FS_WINDOWS, FS_UNIX, FS_NATIVE];
 
 function runInEachFileSystemFn(callback: (os: string) => void) {
-  const isOnCi = !!(process.env.CI || process.env.CIRCLECI || process.env.GITHUB_ACTION);
-
-  // At the time of writing, running the compiler tests on the CI on Windows is flaky and it
-  // appears to be related to mocking out the file system. Since we're running the mocked file
-  // system on the other platforms, we don't have to do so on Windows as well. This logic
-  // disables the mocking to try and reduce the amount of flakes.
-  if (isOnCi && platform() === 'win32') {
-    runInFileSystem(FS_NATIVE, callback, false);
-  } else {
-    FS_ALL.forEach(os => runInFileSystem(os, callback, false));
-  }
+  FS_ALL.forEach(os => runInFileSystem(os, callback, false));
 }
 
 function runInFileSystem(os: string, callback: (os: string) => void, error: boolean) {

packages/compiler-cli/test/ngtsc/BUILD.bazel

@@ -32,9 +32,6 @@ jasmine_node_test(
         "//packages/compiler-cli/src/ngtsc/testing/fake_common:npm_package",
         "//packages/compiler-cli/src/ngtsc/testing/fake_core:npm_package",
     ],
-    # TODO: This target is flaky on Windows due to the global FS sometimes not being set/reset.
-    # See: https://app.circleci.com/pipelines/github/angular/angular/62261/workflows/6a4e952c-3d0b-44ab-b3db-c0a639af6bdc/jobs/1348755.
-    flaky = True,
     shard_count = 4,
     deps = [
         ":ngtsc_lib",