Skip to content

Commit

Permalink
fix(bazel): pin @microsoft/api-extractor (#32187)
Browse files Browse the repository at this point in the history
The API of `@microsoft/api-extractor` changed in a minor version which is causes an error when using dts flattening downstream.

API wil be updated on master #32185

PR Close #32187
  • Loading branch information
alan-agius4 authored and AndrewKushnir committed Aug 19, 2019
1 parent 0b1bf14 commit 5da5ca5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -43,7 +43,7 @@
"@bazel/karma": "0.34.0",
"@bazel/protractor": "0.34.0",
"@bazel/typescript": "0.34.0",
"@microsoft/api-extractor": "^7.0.21",
"@microsoft/api-extractor": "7.0.21",
"@schematics/angular": "^8.0.0-beta.15",
"@types/angular": "^1.6.47",
"@types/base64-js": "1.2.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/bazel/package.json
Expand Up @@ -29,7 +29,7 @@
"@angular-devkit/architect": "^0.800.0-beta.15",
"@angular-devkit/core": "^8.0.0-beta.15",
"@angular-devkit/schematics": "^8.0.0-beta.15",
"@microsoft/api-extractor": "^7.0.21",
"@microsoft/api-extractor": "7.0.21",
"@schematics/angular": "^8.0.0-beta.15",
"@types/node": "6.0.84",
"semver": "^5.6.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Expand Up @@ -301,7 +301,7 @@
through2 "^2.0.0"
xdg-basedir "^3.0.0"

"@microsoft/api-extractor@^7.0.21":
"@microsoft/api-extractor@7.0.21":
version "7.0.21"
resolved "https://registry.yarnpkg.com/@microsoft/api-extractor/-/api-extractor-7.0.21.tgz#d5ff9bba4ff7283503aac83ad489b16cad293fc7"
integrity sha512-7lFcHNykVz0tvgOz9juXqP+a1j0EmnJ9J080CBE/171IxL4fBrpslPhqN86dNuavuPragRpBLc8Okv/bV7FJPQ==
Expand Down

3 comments on commit 5da5ca5

@IgorMinar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this pin the dependency? The dependency is already pinned via the lock file. Can you please elaborate? thanks!

@alan-agius4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin the dependency for users who are using @angular/bazel ng_module bazel rule via npm. (Downstream)

@IgorMinar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. that makes sense! thanks

Please sign in to comment.