Skip to content

Commit

Permalink
feat(ivy): support inline <style> and <link> tags in components (#28997)
Browse files Browse the repository at this point in the history
Angular supports using <style> and <link> tags inline in component
templates, but previously such tags were not implemented within the ngtsc
compiler. This commit introduces that support.

FW-1069 #resolve

PR Close #28997
  • Loading branch information
alxhub authored and benlesh committed Feb 27, 2019
1 parent 40833ba commit 827e89c
Show file tree
Hide file tree
Showing 5 changed files with 321 additions and 129 deletions.
5 changes: 3 additions & 2 deletions aio/tools/examples/run-example-e2e.js
Expand Up @@ -21,8 +21,6 @@ const IGNORED_EXAMPLES = [
];

const fixmeIvyExamples = [
// fixmeIvy('FW-1069: ngtsc does not support inline <style> and <link>')
'component-styles',
// fixmeIvy('unknown') app fails at runtime due to missing external service (goog is undefined)
'i18n'
];
Expand Down Expand Up @@ -319,7 +317,10 @@ function getE2eSpecs(basePath, filter) {
// Find all e2e specs in a given example folder.
function getE2eSpecsFor(basePath, specFile, filter) {
// Only get spec file at the example root.
// The formatter doesn't understand nested template string expressions (honestly, neither do I).
// clang-format off
const e2eSpecGlob = `${filter ? `*${filter}*` : '*'}/${specFile}`;
// clang-format on
return globby(e2eSpecGlob, {cwd: basePath, nodir: true})
.then(
paths => paths.filter(file => !IGNORED_EXAMPLES.some(ignored => file.startsWith(ignored)))
Expand Down

0 comments on commit 827e89c

Please sign in to comment.