Skip to content

Commit

Permalink
docs: add note about only one label target being allowed to be applie…
Browse files Browse the repository at this point in the history
…d to a PR (#38793)

To clarify the use of GitHub labels for targetting PRs, a not about only being
allowed to apply one label is added.

PR Close #38793
  • Loading branch information
josephperrott authored and AndrewKushnir committed Sep 10, 2020
1 parent dcb473d commit 9078187
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions docs/TRIAGE_AND_LABELS.md
@@ -1,6 +1,6 @@
# Triage Process and GitHub Labels for Angular

This document describes how the Angular team uses labels and milestones to triage issues on github.
This document describes how the Angular team uses labels and milestones to triage issues on GitHub.
The basic idea of the process is that caretaker only assigns a component (`comp: *`) label.
The owner of the component is then responsible for the secondary / component-level triage.

Expand Down Expand Up @@ -150,7 +150,7 @@ In addition, PRs can have the following states:
* _**Who adds it:** Any team member._
* _**Who removes it:** Any team member._

When a PR is ready for review, a review should be requested using the Reviewers interface in Github.
When a PR is ready for review, a review should be requested using the Reviewers interface in GitHub.


## PR Target
Expand All @@ -160,7 +160,7 @@ In our git workflow, we merge changes either to the `master` branch, the active
The decision about the target must be done by the PR author and/or reviewer.
This decision is then honored when the PR is being merged by the caretaker.

To communicate the target we use the following labels:
To communicate the target we use GitHub labels and only one target label may be applied to a PR.

Targeting an active release train:

Expand All @@ -176,9 +176,9 @@ Special Cases:

Notes:
- To land a change only in a patch/RC branch, without landing it in any other active release-train branch (such
as `master`), the patch/RC branch can be targeted in the Github UI with the appropriate
as `master`), the patch/RC branch can be targeted in the GitHub UI with the appropriate
`target: patch`/`target: rc` label.
- `target: lts` PRs must target the specific LTS branch they would need to merge into in the Github UI, in
- `target: lts` PRs must target the specific LTS branch they would need to merge into in the GitHub UI, in
cases which a change is desired in multiple LTS branches, individual PRs for each LTS branch must be created


Expand Down

0 comments on commit 9078187

Please sign in to comment.