Skip to content

Commit

Permalink
docs: show overloads for functions
Browse files Browse the repository at this point in the history
  • Loading branch information
JeanMeche committed May 2, 2024
1 parent 48a5ef6 commit 90f5af1
Show file tree
Hide file tree
Showing 6 changed files with 609 additions and 1,442 deletions.
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ yarn_install(
"//:.yarnrc",
"//:tools/npm-patches/@bazel+jasmine+5.8.1.patch",
"//tools:postinstall-patches.js",
"//tools/esm-interop:patches/npm/@angular+build-tooling+0.0.0-e0ec7b60641d7f6369be45d8d02663fd50f320be.patch",
"//tools/esm-interop:patches/npm/@angular+build-tooling+0.0.0-56d0b1f597b9e4b5d99f289f6904a220802164c1.patch",
"//tools/esm-interop:patches/npm/@bazel+concatjs+5.8.1.patch",
"//tools/esm-interop:patches/npm/@bazel+esbuild+5.7.1.patch",
"//tools/esm-interop:patches/npm/@bazel+protractor+5.7.1.patch",
Expand Down
1 change: 1 addition & 0 deletions adev/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ APPLICATION_ASSETS = [
APPLICATION_DEPS = [
"@npm//@angular-devkit/build-angular",
"@npm//@angular/animations",
"@npm//@angular/build",
"@npm//@angular/cdk",
"@npm//@angular/common",
"@npm//@angular/compiler",
Expand Down
2 changes: 1 addition & 1 deletion adev/tools/local_deps/filter_external_npm_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ load("@build_bazel_rules_nodejs//:providers.bzl", "ExternalNpmPackageInfo", "Lin
def _filter_external_npm_deps_impl(ctx):
problematic_paths = ["external/npm/node_modules/%s" % pkg for pkg in ctx.attr.angular_packages]
package_name = ctx.attr.target.label.package
has_problematic_transitive_dep = package_name.startswith("@angular-devkit/")
has_problematic_transitive_dep = package_name.startswith("@angular-devkit/") or package_name.startswith("@angular/build")
filtered_deps = []

# Note: to_list() is expensive; we need to invoke it here to get the path
Expand Down
21 changes: 11 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,13 @@
},
"// 1": "dependencies are used locally and by bazel",
"dependencies": {
"@angular-devkit/build-angular": "18.0.0-next.3",
"@angular-devkit/core": "18.0.0-next.3",
"@angular-devkit/schematics": "18.0.0-next.3",
"@angular/cdk": "18.0.0-next.5",
"@angular/cli": "18.0.0-next.3",
"@angular/material": "18.0.0-next.5",
"@angular/build": "18.0.0-next.5",
"@angular-devkit/build-angular": "18.0.0-next.5",
"@angular-devkit/core": "18.0.0-next.5",
"@angular-devkit/schematics": "18.0.0-next.5",
"@angular/cdk": "18.0.0-next.6",
"@angular/cli": "18.0.0-next.5",
"@angular/material": "18.0.0-next.6",
"@babel/cli": "7.24.1",
"@babel/core": "7.24.4",
"@babel/generator": "7.24.4",
Expand Down Expand Up @@ -153,9 +154,9 @@
"@actions/core": "^1.10.0",
"@angular-devkit/architect-cli": "^0.1800.0-next",
"@angular/animations": "^18.0.0-next",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#5b1b7bc36648f4c066d8cf917ea7cc9e7eed2b8f",
"@angular/docs": "https://github.com/angular/dev-infra-private-docs-builds.git#12016780c96616656ed6667d65860391a5b56c79",
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#6562bdff590d9669e895a8103c02736d805bcbdc",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#b73fac15a76e6b07e59da311a92d4dac869972df",
"@angular/docs": "https://github.com/angular/dev-infra-private-docs-builds.git#c244ce7f690ed5935a4b37c98c41ff136172512d",
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#aa4615918c8cb5d00f77fe6707145e8b321ecf5b",
"@babel/helper-remap-async-to-generator": "^7.18.9",
"@babel/plugin-proposal-async-generator-functions": "^7.20.7",
"@bazel/bazelisk": "^1.7.5",
Expand Down Expand Up @@ -183,6 +184,7 @@
"@types/inquirer": "^9.0.3",
"@types/jsdom": "^21.1.5",
"@typescript/vfs": "^1.5.0",
"@xterm/xterm": "^5.4.0",
"@yarnpkg/lockfile": "^1.1.0",
"adm-zip": "^0.5.10",
"angular-split": "^17.1.1",
Expand Down Expand Up @@ -219,7 +221,6 @@
"typed-graphqlify": "^3.1.1",
"vrsource-tslint-rules": "6.0.0",
"xregexp": "^5.1.1",
"@xterm/xterm": "^5.4.0",
"xterm-addon-fit": "^0.8.0"
},
"// 3": "Ensure that transitive dependencies on `https-proxy-agent` are at minimum v5 as older versions patch NodeJS directly, breaking tools like webdriver which is used by the karma-sauce-launcher as an example.",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/node_modules/@angular/build-tooling/bazel/api-gen/extraction/BUILD.bazel b/node_modules/@angular/build-tooling/bazel/api-gen/extraction/BUILD.bazel
index afe4e5c..095a8f0 100755
index bde72eb..50912e9 100755
--- a/node_modules/@angular/build-tooling/bazel/api-gen/extraction/BUILD.bazel
+++ b/node_modules/@angular/build-tooling/bazel/api-gen/extraction/BUILD.bazel
@@ -1,5 +1,5 @@
Expand Down Expand Up @@ -52,7 +52,7 @@ index 26563a7..f7bc080 100755
+ "@angular//packages/compiler-cli",
],
)

@@ -25,7 +25,7 @@ ts_library(
devmode_module = "commonjs",
tsconfig = "@npm//@angular/build-tooling:tsconfig.json",
Expand All @@ -72,16 +72,16 @@ index 26563a7..f7bc080 100755
entry_point = "bin.mjs",
# Note: Using the linker here as we need it for ESM. The linker is not
diff --git a/node_modules/@angular/build-tooling/bazel/api-gen/rendering/BUILD.bazel b/node_modules/@angular/build-tooling/bazel/api-gen/rendering/BUILD.bazel
index 850265d..68146c8 100755
index f5e01df..1698016 100755
--- a/node_modules/@angular/build-tooling/bazel/api-gen/rendering/BUILD.bazel
+++ b/node_modules/@angular/build-tooling/bazel/api-gen/rendering/BUILD.bazel
@@ -1,5 +1,5 @@
load("@npm//@bazel/concatjs:index.bzl", "ts_library")
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+load("@angular//tools/esm-interop:index.bzl", "nodejs_binary")

package(default_visibility = ["@npm//@angular/build-tooling/bazel/api-gen:__subpackages__"])

diff --git a/node_modules/@angular/build-tooling/bazel/api-golden/index.bzl b/node_modules/@angular/build-tooling/bazel/api-golden/index.bzl
index 6cee158..815a55d 100755
--- a/node_modules/@angular/build-tooling/bazel/api-golden/index.bzl
Expand All @@ -90,7 +90,7 @@ index 6cee158..815a55d 100755
load("@npm//@angular/build-tooling/bazel:extract_types.bzl", "extract_types")
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary", "nodejs_test")
+load("@angular//tools/esm-interop:index.bzl", "nodejs_binary", "nodejs_test")

nodejs_test_args = [
# Needed so that node doesn't walk back to the source directory.
diff --git a/node_modules/@angular/build-tooling/bazel/app-bundling/BUILD.bazel b/node_modules/@angular/build-tooling/bazel/app-bundling/BUILD.bazel
Expand All @@ -100,21 +100,21 @@ index 1c27a95..c239203 100755
@@ -1,4 +1,4 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+load("@angular//tools/esm-interop:index.bzl", "nodejs_binary")

package(default_visibility = ["//visibility:public"])

diff --git a/node_modules/@angular/build-tooling/bazel/app-bundling/esbuild.config-tmpl.mjs b/node_modules/@angular/build-tooling/bazel/app-bundling/esbuild.config-tmpl.mjs
index 81e67de..d1c1ac0 100755
--- a/node_modules/@angular/build-tooling/bazel/app-bundling/esbuild.config-tmpl.mjs
+++ b/node_modules/@angular/build-tooling/bazel/app-bundling/esbuild.config-tmpl.mjs
@@ -7,7 +7,7 @@
*/

import {createEsbuildAngularOptimizePlugin} from '@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs';
-import {GLOBAL_DEFS_FOR_TERSER_WITH_AOT} from '@angular/compiler-cli/private/tooling';
+import {GLOBAL_DEFS_FOR_TERSER_WITH_AOT} from '@angular/compiler-cli/private/tooling.mjs';
import * as path from 'path';

/** Root path pointing to the app bundle source entry-point file. */
diff --git a/node_modules/@angular/build-tooling/bazel/app-bundling/index.bzl b/node_modules/@angular/build-tooling/bazel/app-bundling/index.bzl
index d6249b8..761d50a 100755
Expand All @@ -136,13 +136,13 @@ index 8bfab84..175cc9d 100755
@@ -1,4 +1,4 @@
-load("@npm//@bazel/protractor:index.bzl", "protractor_web_test_suite")
+load("@angular//tools:defaults.bzl", "protractor_web_test_suite")

"""
Macro that can be used to define a benchmark test. This differentiates from
@@ -7,7 +7,7 @@ load("@npm//@bazel/protractor:index.bzl", "protractor_web_test_suite")
unless explicitly requested.
"""

-def benchmark_test(name, server, tags = [], **kwargs):
+def benchmark_test(name, server, tags = [], data = [], **kwargs):
protractor_web_test_suite(
Expand All @@ -168,7 +168,7 @@ index 6213703..0c1d70f 100755
+load("@angular//tools:defaults.bzl", "ng_module")
load("@npm//@bazel/concatjs:index.bzl", "ts_library")
load(":benchmark_test.bzl", "benchmark_test")

@@ -37,8 +37,8 @@ def component_benchmark(
driver_deps,
ng_srcs,
Expand All @@ -186,7 +186,7 @@ index 6213703..0c1d70f 100755
# repository with its corresponding source target that does not come with any typings.
- ng_bundle_deps.append("@npm//zone.js")
+ ng_bundle_deps.append("@angular//packages/zone.js:npm_package")

if not assets:
html = prefix + "index.html"
diff --git a/node_modules/@angular/build-tooling/bazel/http-server/BUILD.bazel b/node_modules/@angular/build-tooling/bazel/http-server/BUILD.bazel
Expand All @@ -197,7 +197,7 @@ index 04cc755..ec01017 100755
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+load("@angular//tools/esm-interop:index.bzl", "nodejs_binary")
load("@npm//@bazel/concatjs:index.bzl", "ts_library")

package(default_visibility = ["//visibility:public"])
diff --git a/node_modules/@angular/build-tooling/bazel/integration/index.bzl b/node_modules/@angular/build-tooling/bazel/integration/index.bzl
index 6f99d65..1bd5183 100755
Expand All @@ -206,7 +206,7 @@ index 6f99d65..1bd5183 100755
@@ -1,4 +1,4 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_test")
+load("@angular//tools/esm-interop:index.bzl", "nodejs_test")

def _serialize_file(file):
"""Serializes a file into a struct that matches the `BazelFileInfo` type in the
diff --git a/node_modules/@angular/build-tooling/bazel/map-size-tracking/index.bzl b/node_modules/@angular/build-tooling/bazel/map-size-tracking/index.bzl
Expand All @@ -216,32 +216,32 @@ index af0f305..ce46302 100755
@@ -3,7 +3,7 @@
# Use of this source code is governed by an MIT-style license that can be
# found in the LICENSE file at https://angular.io/license

-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary", "nodejs_test")
+load("@angular//tools/esm-interop:index.bzl", "nodejs_binary", "nodejs_test")

nodejs_args = ["--nobazel_run_linker"]

diff --git a/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/BUILD.bazel b/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/BUILD.bazel
index 870da1b..e0bdb71 100755
index b2729ad..80ab926 100755
--- a/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/BUILD.bazel
+++ b/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/BUILD.bazel
@@ -43,7 +43,8 @@ js_library(
@@ -24,7 +24,8 @@ js_library(
srcs = [":js_lib_files"],
deps = [
":angular_devkit_plugins",
"@npm//@angular/build",
- "@npm//@angular/compiler-cli",
+ "@angular//packages/compiler-cli",
+ "@angular//packages/compiler-cli/linker/babel",
"@npm//@babel/core",
"@npm//@babel/plugin-proposal-async-generator-functions",
],
diff --git a/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs b/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs
index 6d5ec3f..a4ebfd7 100755
index e79184b..da9e479 100755
--- a/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs
+++ b/node_modules/@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs
@@ -60,8 +60,8 @@ export async function createEsbuildAngularOptimizePlugin(opts, additionalBabelPl

@@ -29,8 +29,8 @@ export async function createEsbuildAngularOptimizePlugin(opts, additionalBabelPl
if (opts.enableLinker) {
linkerCreator = {
- compiler: await import('@angular/compiler-cli'),
Expand All @@ -250,4 +250,4 @@ index 6d5ec3f..a4ebfd7 100755
+ babel: await import('@angular/compiler-cli/linker/babel/index.mjs'),
};
}

0 comments on commit 90f5af1

Please sign in to comment.