Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(compiler): make sure selectors inside container queries are corre…
…ctly scoped (#48353) improve the emulated shadowDom implementation so that it can correctly scope selectors present inside the @container at-rule (recently added to the css specs) resolves #48264 PR Close #48353
- Loading branch information
1 parent
1e58a8c
commit 9a5d842
Showing
2 changed files
with
57 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
packages/compiler/test/shadow_css/container_queries_spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
import {ShadowCss} from '@angular/compiler/src/shadow_css'; | ||
|
||
describe('ShadowCss, container queries', () => { | ||
function s(css: string, contentAttr: string, hostAttr: string = '') { | ||
const shadowCss = new ShadowCss(); | ||
return shadowCss.shimCssText(css, contentAttr, hostAttr); | ||
} | ||
|
||
it('should scope normal selectors inside an unnamed container rules', () => { | ||
const css = `@container max(max-width: 500px) { | ||
.item { | ||
color: red; | ||
} | ||
}`; | ||
const result = s(css, 'host-a'); | ||
expect(noIndentation(result)).toEqual(noIndentation(`@container max(max-width: 500px) { | ||
.item[host-a] { | ||
color: red; | ||
} | ||
}`)); | ||
}); | ||
|
||
it('should scope normal selectors inside a named container rules', () => { | ||
const css = `@container container max(max-width: 500px) { | ||
.item { | ||
color: red; | ||
} | ||
}`; | ||
const result = s(css, 'host-a'); | ||
// Note that for the time being we are not scoping the container name itself, | ||
// this is something that may or may not be done in the future depending | ||
// on how the css specs evolve. Currently as of Chrome 107 it looks like shadowDom | ||
// boundaries don't effect container queries (thus the scoping wouldn't be needed) | ||
// and this aspect of container queries seems to be still under active discussion: | ||
// https://github.com/w3c/csswg-drafts/issues/5984 | ||
expect(noIndentation(result)) | ||
.toEqual(noIndentation(`@container container max(max-width: 500px) { | ||
.item[host-a] { | ||
color: red; | ||
} | ||
}`)); | ||
}); | ||
}); | ||
|
||
function noIndentation(str: string): string { | ||
return str.replace(/\n\s+/g, '\n'); | ||
} |