Skip to content

Commit

Permalink
test(ivy): fined tune micro benchmark parameters (#33341)
Browse files Browse the repository at this point in the history
Decrease `MIN_SAMPLE_DURATION` to make it more likely that we cane fit into single time slice.
Increase `MIN_SAMPLE_COUNT_NO_IMPROVEMENT` to make it more likely to find the best

PR Close #33341
  • Loading branch information
mhevery authored and AndrewKushnir committed Oct 23, 2019
1 parent d40ee6a commit a1d7b6b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/core/test/render3/perf/micro_bench.ts
Expand Up @@ -8,10 +8,10 @@
const performance = require('perf_hooks').performance;

// Higher number here makes it more likely that we are more sure of the result.
const MIN_SAMPLE_COUNT_NO_IMPROVEMENT = 100;
const MIN_SAMPLE_COUNT_NO_IMPROVEMENT = 500;
// A smaller number here means that we are coming too close on timer resultion, but it also means
// that it is less likely that we will be bothered by GC or preemptive multi tasking.
const MIN_SAMPLE_DURATION = 10;
const MIN_SAMPLE_DURATION = 3;

const UNITS = ['ms', 'us', 'ns', 'ps'];
export interface Benchmark {
Expand Down

0 comments on commit a1d7b6b

Please sign in to comment.