fixup! perf(core): use ngDevMode to tree-shake error messages

angular · Sep 1, 2020 · aa01b6a · aa01b6a
1 parent 3566774
commit aa01b6a
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 18 deletions.
diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts
@@ -1393,10 +1393,10 @@ function findDirectiveDefMatches(
                     `Please use a different tag to activate the ${stringify(def.type)} component.`);
 
             if (tNode.flags & TNodeFlags.isComponentHost) throwMultipleComponentError(tNode);
-            markAsComponentHost(tView, tNode);
-            // The component is always stored first with directives after.
-            matches.unshift(def);
           }
+          markAsComponentHost(tView, tNode);
+          // The component is always stored first with directives after.
+          matches.unshift(def);
         } else {
           matches.push(def);
         }

diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@@ -350,9 +350,6 @@
   {
     "name": "setUpAttributes"
   },
-  {
-    "name": "throwMultipleComponentError"
-  },
   {
     "name": "unwrapRNode"
   },

diff --git a/packages/core/test/bundling/forms/bundle.golden_symbols.json b/packages/core/test/bundling/forms/bundle.golden_symbols.json
@@ -1586,12 +1586,6 @@
   {
     "name": "syncPendingControls"
   },
-  {
-    "name": "throwMixedMultiProviderError"
-  },
-  {
-    "name": "throwMultipleComponentError"
-  },
   {
     "name": "toObservable"
   },

diff --git a/packages/core/test/bundling/injection/bundle.golden_symbols.json b/packages/core/test/bundling/injection/bundle.golden_symbols.json
@@ -128,9 +128,6 @@
   {
     "name": "stringify"
   },
-  {
-    "name": "throwMixedMultiProviderError"
-  },
   {
     "name": "ɵɵdefineInjectable"
   },

diff --git a/packages/core/test/bundling/todo/bundle.golden_symbols.json b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@@ -713,9 +713,6 @@
   {
     "name": "stringifyForError"
   },
-  {
-    "name": "throwMultipleComponentError"
-  },
   {
     "name": "toTStylingRange"
   },