fix(compiler): handle trailing comma in object literal (#49535)

Fixes that the compiler wasn't parsing an object literal with a trailing comma correctly. Fixes #49534. PR Close #49535
angular · Mar 23, 2023 · c3cff35 · c3cff35
1 parent a844435
commit c3cff35
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/compiler/src/expression_parser/parser.ts b/packages/compiler/src/expression_parser/parser.ts
@@ -949,7 +949,8 @@ export class _ParseAST {
           values.push(new PropertyRead(
               span, sourceSpan, sourceSpan, new ImplicitReceiver(span, sourceSpan), key));
         }
-      } while (this.consumeOptionalCharacter(chars.$COMMA));
+      } while (this.consumeOptionalCharacter(chars.$COMMA) &&
+               !this.next.isCharacter(chars.$RBRACE));
       this.rbracesExpected--;
       this.expectCharacter(chars.$RBRACE);
     }

diff --git a/packages/compiler/test/expression_parser/parser_spec.ts b/packages/compiler/test/expression_parser/parser_spec.ts
@@ -116,6 +116,7 @@ describe('parser', () => {
         checkAction('{}');
         checkAction('{a: 1, "b": 2}[2]');
         checkAction('{}["a"]');
+        checkAction('{a: 1, b: 2,}', '{a: 1, b: 2}');
       });
 
       it('should only allow identifier, string, or keyword as map key', () => {