Skip to content

Commit

Permalink
build: temporarily set build --define=enable_legacy_rollup_rule=1 i…
Browse files Browse the repository at this point in the history
…n bazelrc (#33426)

Temporary define while angular depends on the legacy rollup_bundle rule. This will be removed after #33201 lands.

PR Close #33426
  • Loading branch information
gregmagolan authored and AndrewKushnir committed Oct 28, 2019
1 parent d8d8b89 commit eb0d8c0
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .bazelrc
Expand Up @@ -71,6 +71,13 @@ test --test_output=errors
# any bazel target. This is a temporary flag until codebase is permanently switched to Ivy.
build --define=compile=legacy

################################
# Settings for rules_nodejs #
################################
# Temporary define while angular depends on the legacy rollup_bundle rule.
# TODO: remove this setting after https://github.com/angular/angular/pull/33201 lands.
build --define=enable_legacy_rollup_rule=1

#######################
# Remote HTTP Caching #
#######################
Expand Down
4 changes: 4 additions & 0 deletions integration/bazel/.bazelrc
Expand Up @@ -14,6 +14,10 @@ build --local_resources=14336,8.0,1.0
# Use the Angular 6 compiler
build --define=compile=legacy

# Temporary define while angular depends on the legacy rollup_bundle rule.
# TODO: remove this setting after https://github.com/angular/angular/pull/33201 lands.
build --define=enable_legacy_rollup_rule=1

# Don't create symlinks
build --symlink_prefix=/

Expand Down
4 changes: 4 additions & 0 deletions packages/bazel/src/builders/files/__dot__bazelrc.template
Expand Up @@ -30,6 +30,10 @@ test --test_output=errors
# Use the Angular 6 compiler
build --define=compile=legacy

# Temporary define while angular depends on the legacy rollup_bundle rule.
# TODO: remove this setting after https://github.com/angular/angular/pull/33201 lands.
build --define=enable_legacy_rollup_rule=1

# Turn on managed directories feature in Bazel
# This allows us to avoid installing a second copy of node_modules
common --experimental_allow_incremental_repository_updates

0 comments on commit eb0d8c0

Please sign in to comment.