Can't extend IterableDiffers

[barbatus]

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Not sure If I am missing something or it's a bug.
But if you do as follows I get "Cannot extend IterableDiffers without a parent injector" exception.

@NgModule({
  imports: [BrowserModule],
  providers: [IterableDiffers.extend([new FooIterableDifferFactory()])]
  bootstrap: [Foo]
});
export class AppModule { }

platformBrowserDynamic().bootstrapModule(AppModule);

Expected/desired behavior

It's possible to extend default iterable differs in the application module.

Please tell us about your environment:

• Angular version: 2.0.0-rc.6
• Browser: [all]
• Language: [all]

[vicb]

Expected/desired behavior

Pls expand on what you're trying to do

[Urigo]

As @barbatus said, it's was possible to extend default iterable differs in Components, like here, but now it's not anymore, only available in module providers.

@vicb we are using it in angular2-meteor in order to provide new iterable for Mongo Cursor changes (you can see this file).

As I understand, we moved to use ES6 bundle in the latest version and so we can't access the internal code, so it related to that issue were we asked to export that code for external usage.

Thanks!

[vicb]

Could you please craft a before/after plunker - is this broken in RC6 ?

It's true that deep imports are not allowed any more, might be the issue.

Thanks

[barbatus]

@vicb Here is a plunker where a custom differ factory is supposed to be used but it throws "Cannot extend IterableDiffers without a parent injector" when I am trying to use IterableDiffers.extend.
https://plnkr.co/edit/YVRZ6gNq7LMr2DAJvRAf?p=preview

As before, we extended standard differs by providing new instance of IterableDiffers with all differ factories added plus our custom differ factory. In order to get all available differ factories to pass them into IterableDiffers constructor, we relied on some internal code, i.e. https://github.com/Urigo/angular2-meteor/blob/master/modules/providers.ts#L6

It's be awesome if you made access to the standard differ factory public (i.e. this one
https://github.com/angular/angular/blob/master/modules/%40angular/core/src/change_detection/change_detection.ts#L35), so we could use it to extend IterableDiffers in the same way as before,
or made IterableDiffers.extend is not dependable on the default differ.

[htafolla]

@vicb is this scheduled to be resolved in the next maintenance release? There is a growing community looking to use Angular 2.0.0 with Meteor. Based on the latest posts on the corresponding thread, this item is the only one remaining to make the jump.

[vicb]

@htafolla I'm going to take a look asap.

[vicb]

just discussed with @vsavkin, we should have a solution by the next release (probably 2.0.1)

[vicb]

for now a workaround would be not to add the providers in the app module but in a child module.

[barbatus]

@vicb I added it to a module https://plnkr.co/edit/UCKeZGwKfENQY76RHgiy?p=preview, still same exception. I also tried as ModuleWithProviders, also doesn't help.

[chrisse27]

@barbatus Adding it as provider to the child component works for me: https://plnkr.co/edit/IZcErDswbe6CLSZOwVve

That's also what I did with the METEOR_PROVIDERs to get rid of the exception in my angular2 meteor project.

[barbatus]

@chrisse27 yes, but providers for things like IterableDiffers make sense to set globally for all components not for every one.

[chrisse27]

@barbatus I agree, but if I set the provider on my app component then it will be available in all injectors of child components as well.

[barbatus]

@chrisse27 hm, this is how it was before. I thought for some reason they got (or gonna get) rid of providers in components. Anyways makes sense to fix it for modules as well.

[barbatus]

@chrisse27 this also https://angular.io/docs/ts/latest/cookbook/ngmodule-faq.html#!#q-component-or-module. For the apps with routes, there is no one root component as well.

[DzmitryShylovich]

@barbatus did your solve the issue?

[barbatus]

@DzmitryShylovich I could only work around it. Status of this issue clear states it's not fixed yet.
So either a fix is needed or docs update to note that IterableDiffers is not extendable in @NgModule.

[DzmitryShylovich]

@barbatus could u add a small repro in plunkr?

[barbatus]

@DzmitryShylovich ok, there was one above which seems to be broken now.
Here is new one https://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5?p=preview

UPD: correct link https://plnkr.co/edit/wV5vrEOStbpH1Vmq1n0B?p=preview

[staeke]

Ping! What's the status of this @DzmitrySchylovic?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}