fix(service-worker): ignore passive mixed content requests #25994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
type: bug/fix
action: review
|
You can preview ab01ebc at https://pr25994-ab01ebc.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-sw-passive-mixed-content
branch
2 times, most recently
from
ea58b3b
to
ba751f0
Compare
|
You can preview ba751f0 at https://pr25994-ba751f0.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-sw-passive-mixed-content
branch
from
ba751f0
to
805c538
Compare
|
You can preview 805c538 at https://pr25994-805c538.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-sw-passive-mixed-content
branch
from
805c538
to
b8ced23
Compare
|
You can preview b8ced23 at https://pr25994-b8ced23.ngbuilds.io/. |
IgorMinar
approved these changes
Mar 2, 2019
IgorMinar
added
action: merge
|
this PR needs a rebase to drop the pull approve pending check - otherwise lgtm |
IgorMinar
added
the
merge: caretaker note
|
merge-assistance: please rebase before merging and verify that the CI is still green, if not please ask @gkalpak to help |
Although [passive mixed content][1] requests (like images) only produce a warning without a ServiceWorker, fetching it via a ServiceWorker results in an error. See angular#23012 (comment) for more details. This commit makes the ServiceWorker ignore such requests and let them be handled by the browser directly to avoid breaking apps that would work without the ServiceWorker. [1]: https://developers.google.com/web/fundamentals/security/prevent-mixed-content/what-is-mixed-content#passive_mixed_content Fixes angular#23012
AndrewKushnir
force-pushed
the
fix-sw-passive-mixed-content
branch
from
b8ced23
to
cc6da57
Compare
AndrewKushnir
added
the
action: cleanup
AndrewKushnir
removed
the
action: merge
|
@gkalpak I've rebased this PR on top of the latest master. Could you please have a quick look at the changes to see if everything looks good and put the "merge" label back? Thank you. |
gkalpak
added
action: merge
|
@AndrewKushnir, looks good. Thx! |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 4, 2019
Although [passive mixed content][1] requests (like images) only produce a warning without a ServiceWorker, fetching it via a ServiceWorker results in an error. See #23012 (comment) for more details. This commit makes the ServiceWorker ignore such requests and let them be handled by the browser directly to avoid breaking apps that would work without the ServiceWorker. [1]: https://developers.google.com/web/fundamentals/security/prevent-mixed-content/what-is-mixed-content#passive_mixed_content Fixes #23012 PR Close #25994
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
Passive mixed content requests (like images) result in an error. This is a ServiceWorker limitation. Without the ServiceWorker, such requests only produce a warning. See #23012 (comment) for more details.
Issue Number: #23012
What is the new behavior?
The ServiceWorker will ignore such requests and let them be handled by the browser directly.
Does this PR introduce a breaking change?
Other information
Fixes #23012.