Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service-worker): ignore passive mixed content requests #25994

Closed
wants to merge 1 commit into from
Closed

fix(service-worker): ignore passive mixed content requests #25994

wants to merge 1 commit into from

Commits on Mar 4, 2019

  1. fix(service-worker): ignore passive mixed content requests 

    Although [passive mixed content][1] requests (like images) only produce
a warning without a ServiceWorker, fetching it via a ServiceWorker
results in an error. See
angular#23012 (comment)
for more details.

This commit makes the ServiceWorker ignore such requests and let them be
handled by the browser directly to avoid breaking apps that would work
without the ServiceWorker.

[1]: https://developers.google.com/web/fundamentals/security/prevent-mixed-content/what-is-mixed-content#passive_mixed_content

Fixes angular#23012
    @gkalpak @AndrewKushnir
    gkalpak authored and AndrewKushnir committed Mar 4, 2019
    Copy the full SHA
    cc6da57 View commit details
    Browse the repository at this point in the history