Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size regression in cli-hello-world-ivy-minimal integration test #43568

Closed
alan-agius4 opened this issue Sep 24, 2021 · 4 comments
Closed

Size regression in cli-hello-world-ivy-minimal integration test #43568

alan-agius4 opened this issue Sep 24, 2021 · 4 comments
Assignees
Labels
area: testing Issues related to Angular testing features, such as TestBed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@alan-agius4
Copy link
Contributor

alan-agius4 commented Sep 24, 2021

Which @angular/* package(s) are the source of the bug?

Don't known / other

Is this a regression?

Yes

Description

The cli-hello-world-ivy-minimal payload size limit has been increased from 17597 to 20064 in https://github.com/angular/angular/pull/43417/files. This has been done as a workaround to bump the Angular tooling packages to version 13.

The regression appears to have been introduced in Angular CLI 12.1.x, when the CLI migrated to use the new Babel based build-optimizer.

Likely we missed some PURE annotations in #43344

This is also a side-effect that the framework is using https://github.com/filipesilva/check-side-effects to check for side effects which uses the deprecated @angular-devkit/build-optimizer

@alan-agius4 alan-agius4 added the area: testing Issues related to Angular testing features, such as TestBed label Sep 24, 2021
@ngbot ngbot bot added this to the needsTriage milestone Sep 24, 2021
@alan-agius4 alan-agius4 changed the title Size regression in cli-hello-world-ivy-minimal integration test Size regression in cli-hello-world-ivy-minimal integration test Sep 24, 2021
@devversion
Copy link
Member

@alan-agius4 Just wanted to check on this. Have you looked into this?

@alan-agius4
Copy link
Contributor Author

@devversion, not yet.

@alxhub alxhub added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 16, 2022
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 16, 2022
@alan-agius4
Copy link
Contributor Author

Closing as this test no longer exists.

@alan-agius4 alan-agius4 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: testing Issues related to Angular testing features, such as TestBed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

3 participants