Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooling packages to version 13. #43417

Closed
wants to merge 6 commits into from
Closed

Update tooling packages to version 13. #43417

wants to merge 6 commits into from

Conversation

alan-agius4
Copy link
Contributor

This is a followup on #43343

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Sep 10, 2021
@google-cla google-cla bot added the cla: yes label Sep 10, 2021
@alan-agius4 alan-agius4 added the area: build & ci Related the build and CI infrastructure of the project label Sep 10, 2021
@ngbot ngbot bot added this to the Backlog milestone Sep 10, 2021
@alan-agius4

This comment has been minimized.

@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Sep 23, 2021

@AndrewKushnir & @petebacondarwin can I get a review for size-tracking please?

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

@pullapprove pullapprove bot requested a review from alxhub September 23, 2021 18:18
`extractCss` option has been removed without replacement.
With this change we update the integration payload size checks golden file to reflect the file names in version 13.

Some considering about the increased in file sizes
- The increase in runtime is caused by inrtroduction of Trusted Types in CLI 12.1 which causes addition bytes to be included in the file
- Other increase/decreases are caused by changes of the minifier. Since the CLI now uses ESbuild as primary minifier instead of terser.
As a result of dropping differential loading, In version 13 the Angular CLI no longer generates files prefixed with the ECMA version.
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we have an issue to track the size regression

Reviewed-for: size-tracking

@@ -27,7 +27,7 @@
"translated:legacy-xlf:update-translations": "node scripts/update-xlf-translation-file.js \"../tmp/legacy-locales/messages.legacy.xlf\"",
"translated:legacy-xmb:test": "yarn ng build && yarn extract --format xmb --outputPath ../tmp/legacy-locales/messages.legacy.xmb && yarn translated:legacy-xmb:update-translations && yarn ng build --configuration=translated-legacy-xmb && yarn translated:legacy:translate -t \"../tmp/legacy-locales/messages.legacy.xtb\" && yarn translated:legacy:e2e",
"translated:legacy-xmb:update-translations": "node scripts/update-xmb-translation-file.js \"../tmp/legacy-locales/messages.legacy.xmb\"",
"extract": "localize-extract --source dist/main-es2015*.js"
"extract": "localize-extract --source dist/main*.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

"@angular-devkit/core": "12.0.4",
"@angular-devkit/schematics": "12.0.4",
"@angular/cli": "12.0.4",
"@angular-devkit/build-angular": "13.0.0-next.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to bump these versions regularly until we hit 13.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will be done automatically through Renovate.

@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 24, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 24, 2021
@alxhub alxhub closed this in 880f021 Sep 24, 2021
alxhub pushed a commit that referenced this pull request Sep 24, 2021
alxhub pushed a commit that referenced this pull request Sep 24, 2021
…#43417)

`extractCss` option has been removed without replacement.

PR Close #43417
alxhub pushed a commit that referenced this pull request Sep 24, 2021
With this change we update the integration payload size checks golden file to reflect the file names in version 13.

Some considering about the increased in file sizes
- The increase in runtime is caused by inrtroduction of Trusted Types in CLI 12.1 which causes addition bytes to be included in the file
- Other increase/decreases are caused by changes of the minifier. Since the CLI now uses ESbuild as primary minifier instead of terser.

PR Close #43417
alxhub pushed a commit that referenced this pull request Sep 24, 2021
As a result of dropping differential loading, In version 13 the Angular CLI no longer generates files prefixed with the ECMA version.

PR Close #43417
@alan-agius4 alan-agius4 deleted the update-cli-packages-v13 branch September 24, 2021 17:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants