New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tooling packages to version 13. #43417
Conversation
This comment has been minimized.
This comment has been minimized.
@AndrewKushnir & @petebacondarwin can I get a review for size-tracking please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: size-tracking
This is a followup on #43343
With this change we update various browserslist configuration file to match newly generated projects. https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/application/files/.browserslistrc.template
`extractCss` option has been removed without replacement.
With this change we update the integration payload size checks golden file to reflect the file names in version 13. Some considering about the increased in file sizes - The increase in runtime is caused by inrtroduction of Trusted Types in CLI 12.1 which causes addition bytes to be included in the file - Other increase/decreases are caused by changes of the minifier. Since the CLI now uses ESbuild as primary minifier instead of terser.
As a result of dropping differential loading, In version 13 the Angular CLI no longer generates files prefixed with the ECMA version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as we have an issue to track the size regression
Reviewed-for: size-tracking
@@ -27,7 +27,7 @@ | |||
"translated:legacy-xlf:update-translations": "node scripts/update-xlf-translation-file.js \"../tmp/legacy-locales/messages.legacy.xlf\"", | |||
"translated:legacy-xmb:test": "yarn ng build && yarn extract --format xmb --outputPath ../tmp/legacy-locales/messages.legacy.xmb && yarn translated:legacy-xmb:update-translations && yarn ng build --configuration=translated-legacy-xmb && yarn translated:legacy:translate -t \"../tmp/legacy-locales/messages.legacy.xtb\" && yarn translated:legacy:e2e", | |||
"translated:legacy-xmb:update-translations": "node scripts/update-xmb-translation-file.js \"../tmp/legacy-locales/messages.legacy.xmb\"", | |||
"extract": "localize-extract --source dist/main-es2015*.js" | |||
"extract": "localize-extract --source dist/main*.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
"@angular-devkit/core": "12.0.4", | ||
"@angular-devkit/schematics": "12.0.4", | ||
"@angular/cli": "12.0.4", | ||
"@angular-devkit/build-angular": "13.0.0-next.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to bump these versions regularly until we hit 13.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will be done automatically through Renovate.
…ts (#43417) With this change we update various browserslist configuration file to match newly generated projects. https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/application/files/.browserslistrc.template PR Close #43417
With this change we update the integration payload size checks golden file to reflect the file names in version 13. Some considering about the increased in file sizes - The increase in runtime is caused by inrtroduction of Trusted Types in CLI 12.1 which causes addition bytes to be included in the file - Other increase/decreases are caused by changes of the minifier. Since the CLI now uses ESbuild as primary minifier instead of terser. PR Close #43417
As a result of dropping differential loading, In version 13 the Angular CLI no longer generates files prefixed with the ECMA version. PR Close #43417
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is a followup on #43343