Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): template type checking should consider non-decorated base c… #31214

Closed
wants to merge 1 commit into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented Jun 22, 2019

…lasses

WIP

Fixes #30080

@JoostK
Copy link
Member Author

JoostK commented Jun 22, 2019

This is a first stab at supporting this use-case. The situation where an entirely natural class (without any Angular decorators) exists within the inheritance chain is still not handled properly, as the entire directive would then get flagged as 'dynamic' which affects the template type checking in an undesirable way.

@JoostK
Copy link
Member Author

JoostK commented Jul 1, 2019

Holding off from this for now as there's plans to move away from BaseDef to just DirectiveDef.

@JoostK JoostK closed this Aug 1, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inputs are not inherited when Ivy is enabled
2 participants