Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zone.js): __load_patch and __symbol__ should be in zone_extern for closure compiler #31350

Closed
wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

@JiaLiPassion JiaLiPassion commented Jun 29, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #30533
If we use Zone.__symbol__ in application or angular code, after closure compiler, the __symbol__ will be gone, because this API is internal and not exist in extern declaration file zone_extern.js. We need to add those APIs (symbol and __load_patch) because they are also public APIs.

What is the new behavior?

__symbol__ and __load_patch becomes public APIs.

Does this PR introduce a breaking change?

  • Yes
  • No

#30533 need this PR to work.

@ngbot ngbot bot added this to the needsTriage milestone Jun 29, 2019
@JiaLiPassion JiaLiPassion changed the title fix(zone.js): __load_patch and __symbol__ should be in zone_extern fo… fix(zone.js): __load_patch and __symbol__ should be in zone_extern for closure compiler Jun 29, 2019
@JiaLiPassion JiaLiPassion requested a review from mhevery July 1, 2019 17:35
packages/zone.js/lib/zone.ts Outdated Show resolved Hide resolved
packages/zone.js/lib/zone.ts Outdated Show resolved Hide resolved
@mhevery mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 12, 2019
@JiaLiPassion JiaLiPassion requested a review from a team as a code owner July 12, 2019 21:33
@JiaLiPassion JiaLiPassion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 12, 2019
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jul 22, 2019
@mhevery
Copy link
Contributor

mhevery commented Jul 22, 2019

presubmit

@mhevery mhevery added the target: major This PR is targeted for the next major release label Jul 24, 2019
@mhevery mhevery closed this in 6b51ed2 Jul 24, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: zones cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants