Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): add support for text replacement #33091

Closed
wants to merge 9 commits into from

Commits on Oct 26, 2019

  1. feat(language-service): add support for text replacement

    Adds a `replacementSpan` field on a completion that will allow typed
    text to be replaced with the suggested completion value if a user
    selects the completion. Previously, the completion value would simply be
    appended to the text already typed. E.g. if we had
    
    ```
    {{ti}}
    ```
    
    typed in a template and `title` was recommended as a completion and
    selected, the template would become
    
    ```
    {{tititle}}
    ```
    
    With `replacementSpan`, the original text `ti` will be replaced for
    `title`.
    ayazhafiz committed Oct 26, 2019
    Copy the full SHA
    36eb606 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e519471 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    fd03f86 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    94472e2 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    0408f32 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    f605079 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    b81a583 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    40920d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Copy the full SHA
    72431f7 View commit details
    Browse the repository at this point in the history