Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): remove unused CLI private exports #33242

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/compiler-cli/index.ts
Expand Up @@ -21,10 +21,8 @@ export * from './src/transformers/entry_points';
export * from './src/perform_compile';
export * from './src/tooling';

// TODO(tbosch): remove this once cli 1.5 is fully released,
// and usages in G3 are changed to `CompilerOptions`.
// TODO(tbosch): remove this once usages in G3 are changed to `CompilerOptions`
export {CompilerOptions as AngularCompilerOptions} from './src/transformers/api';
export {NgTools_InternalApi_NG_2 as __NGTOOLS_PRIVATE_API_2} from './src/ngtools_api';

export {ngToTsDiagnostic} from './src/transformers/util';
export {NgTscPlugin} from './src/ngtsc/tsc_plugin';
Expand Down
8 changes: 0 additions & 8 deletions packages/compiler-cli/ngtools2.ts

This file was deleted.

133 changes: 0 additions & 133 deletions packages/compiler-cli/src/ngtools_api.ts

This file was deleted.

149 changes: 0 additions & 149 deletions packages/compiler-cli/src/ngtools_api2.ts

This file was deleted.

30 changes: 0 additions & 30 deletions packages/compiler-cli/test/BUILD.bazel
Expand Up @@ -98,36 +98,6 @@ jasmine_node_test(
],
)

# ngctools_api_spec
ts_library(
name = "ngtools_api_lib",
testonly = True,
srcs = [
"ngtools_api_spec.ts",
],
deps = [
":test_utils",
"//packages/compiler",
"//packages/compiler-cli",
"//packages/private/testing",
"@npm//typescript",
],
)

jasmine_node_test(
name = "ngtools_api",
bootstrap = ["angular/tools/testing/init_node_spec.js"],
data = [
"//packages/core:npm_package",
"//packages/router:npm_package",
],
deps = [
":ngtools_api_lib",
"//packages/core",
"//tools/testing:node",
],
)

# perform_watch_spec
ts_library(
name = "perform_watch_lib",
Expand Down