refactor(ivy): remove ngBaseDef

[crisbeto]

Removes ngBaseDef from the compiler and any runtime code that was still referring to it. In the cases where we'd previously generate a base def we now generate a definition for an abstract directive.

[AndrewKushnir]

Initial set of presubmits:

• VE Presubmit
• Ivy Presubmit

[AndrewKushnir]

Quick update after running presubmit in g3: it looks like there are some regressions, but they seem to be caused by the fact that there is a problem with inheriting inputs from base classes (annotated with @Directive()), which is used in this PR as a replacement for ngBaseDef. The problem should be resolved by PR #33131, but it's hard to tell whether it's the only problem in g3 or not. My proposal is to land PR #33131 first, rebase this PR and run g3 presubmit again (if time permits). As an option, we can create a draft PR that would include the changes from this PR and PR #33131 to see if there are any regressions in g3. Thank you.

[crisbeto]

Are those compile-time errors or runtime? If I remember correctly, we have a lot of inheritance tests for the runtime which are passing.

[AndrewKushnir]

@crisbeto yes, the errors happen at runtime, so I guess I was incorrect assuming that #33131 will fix those. Let me collect more information and get back with specific use-cases that regressed. Thank you.

[AndrewKushnir]

FYI, VE and Ivy presubmits were successful (g3 regression was resolved) at the point when I started them (see my comment here). I believe CI was "green" at that time as well, so I'm wondering if we can roll back recent changes (based on CR) in this PR if they are not critical, so we can unblock this PR. The remaining comments/improvements (if they are not critical) can be performed as a followup, especially given that we became blocked on #32987.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[alxhub]

Caretaker: these are being done preemptively. Once #32987 lands, this should be in a good state.

Presubmit
Ivy Presubmit

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}