Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ivy): allow the locale to be set via a global property #33314

Closed
wants to merge 8 commits into from
Closed

feat(ivy): allow the locale to be set via a global property #33314

wants to merge 8 commits into from

Commits on Oct 24, 2019

  1. build: add non-ivy test script to package.json 

    This makes it easier to run non-ivy tests locally.
    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    34f68d5 View commit details
    Browse the repository at this point in the history

  2. feat(ivy): allow the locale to be set via a global property 

    In the post-$localize world the current locale value is defined by setting
`$localize.locale` which is then read at runtime by Angular in the provider
for the `LOCALE_ID` token and also passed to the ivy machinery via`setLocaleId()`.

The $localize compile-time inlining tooling can replace occurrences of
`$localize.locale` with a string literal, similar to how translations
are inlined.

// FW-1639

See angular/angular-cli#15896
    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    0bf7bf8 View commit details
    Browse the repository at this point in the history

  3. fixup! feat(ivy): allow the locale to be set via a global property

    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    c98d912 View commit details
    Browse the repository at this point in the history

  4. refactor(ivy): i18n - create and use isLocalize() helper

    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    6142fba View commit details
    Browse the repository at this point in the history

  5. feat(ivy): i18n - inline current locale at compile-time 

    During compile-time translation inlining, the `$localize.locale`
expression will now be replaced with a string literal containing the
current locale of the translations.
    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    f3197bf View commit details
    Browse the repository at this point in the history

  6. fixup! feat(ivy): i18n - inline current locale at compile-time

    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    8e8c140 View commit details
    Browse the repository at this point in the history

  7. test: update ivy i18n integration test 

    The integration test now checks that the locale inlining is working.
    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    19ca362 View commit details
    Browse the repository at this point in the history

  8. fixup! test: update ivy i18n integration test

    @petebacondarwin
    petebacondarwin committed Oct 24, 2019
    Copy the full SHA
    3b15764 View commit details
    Browse the repository at this point in the history