Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): apply [style]/[class] bindings directly to style/className #33336

Closed
wants to merge 2 commits into from

Commits on Oct 24, 2019

  1. perf(ivy): apply [style]/[class] bindings directly to style/className

    This patch ensures that the `[style]` and `[class]` based bindings
    are directly applied to an element's style and className attributes.
    
    This patch optimizes the algorithm so that it...
    - Doesn't construct an update an instance of `StylingMapArray` for
      `[style]` and `[class]` bindings
    - Doesn't apply `[style]` and `[class]` based entries using
      `classList` and `style` (direct attributes are used instead)
    - Doesn't split or iterate over all string-based tokens in a
      string value obtained from a `[class]` binding.
    
    This patch speeds up the following cases:
    - `<div [class]>` and `<div class="..." [class]>`
    - `<div [style]>` and `<div style="..." [style]>`
    
    The overall speec increase is by over 5x.
    matsko committed Oct 24, 2019
    Copy the full SHA
    652f090 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    82149a1 View commit details
    Browse the repository at this point in the history