Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update CLI and related dependencies #33382

Closed
wants to merge 1 commit into from
Closed

build: update CLI and related dependencies #33382

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

This commit also ensures that the integration tests
are all using the top level dependencies.

Resolves #33314 (comment)

@petebacondarwin
build: update CLI and related dependencies
2bece81 
This commit also ensures that the integration tests
are all using the top level dependencies.

Resolves angular#33314 (comment)
@petebacondarwin petebacondarwin added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 24, 2019
@petebacondarwin petebacondarwin requested review from a team as code owners October 24, 2019 19:02
@ngbot ngbot bot modified the milestone: needsTriage Oct 24, 2019
@petebacondarwin petebacondarwin mentioned this pull request Oct 24, 2019
Closed
IgorMinar
IgorMinar approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 24, 2019
@petebacondarwin petebacondarwin deleted the update-cli branch October 25, 2019 06:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petebacondarwin @IgorMinar @googlebot