Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): handle elements with local refs in i18n blocks #33415

Closed
wants to merge 2 commits into from
Closed

fix(ivy): handle elements with local refs in i18n blocks #33415

wants to merge 2 commits into from

Commits on Oct 29, 2019

  1. fix(ivy): handle elements with local refs in i18n blocks 

    Prior to this commit, i18n logic which ensures that elements removed in a translation are also removed in DOM, didn't take into account the fact that elements may have local refs. As a result, remove operation failed, since there is no corresponding tNode found. This commit updates the logic to skip all local refs while going though the list of nodes to ensure that DOM matches elements present in translation.
    @AndrewKushnir
    AndrewKushnir committed Oct 29, 2019
    Copy the full SHA
    d914bd5 View commit details
    Browse the repository at this point in the history

  2. fixup! fix(ivy): handle elements with local refs in i18n blocks

    @AndrewKushnir
    AndrewKushnir committed Oct 29, 2019
    Copy the full SHA
    0b3ad9d View commit details
    Browse the repository at this point in the history