Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ivy): graceful evaluation of unknown or invalid expressions #33453

Closed
wants to merge 1 commit into from

Commits on Oct 31, 2019

  1. feat(ivy): graceful evaluation of unknown or invalid expressions

    During static evaluation of expressions within ngtsc, it may occur that
    certain expressions or just parts thereof cannot be statically
    interpreted for some reason. The static interpreter keeps track of the
    failure reason and the code path that was evaluated by means of
    `DynamicValue`, which will allow descriptive errors. In some situations
    however, the static interpreter would throw an exception instead,
    resulting in a crash of the compilation. Not only does this cause
    non-descriptive errors, more importantly does it prevent the evaluated
    result from being partial, i.e. parts of the result can be dynamic if
    their value does not have to be statically available to the compiler.
    
    This commit refactors the static interpreter to never throw errors for
    certain expressions that it cannot evaluate.
    
    Resolves FW-1582
    JoostK committed Oct 31, 2019
    Copy the full SHA
    737fa0f View commit details
    Browse the repository at this point in the history