Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown pipe & local ref diagnostics #33454

Closed
wants to merge 2 commits into from
Closed

Unknown pipe & local ref diagnostics #33454

wants to merge 2 commits into from

Commits on Oct 30, 2019

  1. fix(ivy): don't crash on an unknown localref target 

    Previously the template binder would crash when encountering an unknown
localref (# reference) such as `<div #ref="foo">` when no directive has
`exportAs: "foo"`.

With this commit, the compiler instead generates a template diagnostic error
informing the user about the invalid reference.
    @alxhub
    alxhub committed Oct 30, 2019
    Copy the full SHA
    c9ea904 View commit details
    Browse the repository at this point in the history

  2. fix(ivy): don't crash on unknown pipe 

    Previously the compiler would crash if a pipe was encountered which did not
match any pipe in the scope of a template.

This commit introduces a new diagnostic error for unknown pipes instead.
    @alxhub
    alxhub committed Oct 30, 2019
    Copy the full SHA
    8ee5c22 View commit details
    Browse the repository at this point in the history