Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): ViewRef.rootNodes returns rootNodes from child views as well #33457

Closed
wants to merge 5 commits into from
Closed

fix(ivy): ViewRef.rootNodes returns rootNodes from child views as well #33457

wants to merge 5 commits into from

Commits on Oct 28, 2019

  1. fix(ivy): ViewRef.rootNodes returns rootNodes from child views as w… 

    …ell.

The idea behind `rootNodes` is to return all of the nodes which need
to be added to the DOM in order for the `ViewRef` to be rendered.
The new implementation correctly takes into account the case where
one of the rootNodes is a container containing other `ViewRef`s.
    @mhevery
    mhevery committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    8d371fa View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. fixup! fix(ivy): ViewRef.rootNodes returns rootNodes from child vie… 

    …ws as well.
    @mhevery
    mhevery committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    dc424ff View commit details
    Browse the repository at this point in the history

  2. fixup! fix(ivy): ViewRef.rootNodes returns rootNodes from child vie… 

    …ws as well.
    @mhevery
    mhevery committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    6a4f953 View commit details
    Browse the repository at this point in the history

  3. fixup! fix(ivy): ViewRef.rootNodes returns rootNodes from child vie… 

    …ws as well.
    @mhevery
    mhevery committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    7cfeec9 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. fixup! fix(ivy): ViewRef.rootNodes returns rootNodes from child vie… 

    …ws as well.
    @mhevery
    mhevery committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    f27a91e View commit details
    Browse the repository at this point in the history