Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): i18n - add XMB e2e integration test #33462

Closed
wants to merge 2 commits into from
Closed

test(ivy): i18n - add XMB e2e integration test #33462

wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Member

This integration test now does a full e2e test of:

  • extraction -> build -> translation - serve

for both XLIFF 1.2 and XMB formats.

Resolves #33444 (comment)

@petebacondarwin
test(ivy): i18n - add XMB e2e integration test
58fb152 
This integration test now does a full e2e test of:

* extraction -> build -> translation - serve

for both XLIFF 1.2 and XMB formats.

Resolves angular#33444 (comment)
@petebacondarwin petebacondarwin added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: major This PR is targeted for the next major release comp: ivy labels Oct 29, 2019
@petebacondarwin petebacondarwin requested a review from a team as a code owner October 29, 2019 11:28
@ngbot ngbot bot modified the milestone: needsTriage Oct 29, 2019
AndrewKushnir
AndrewKushnir approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 29, 2019
@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Oct 29, 2019
josephperrott
josephperrott approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndrewKushnir pushed a commit that referenced this pull request Oct 29, 2019
@petebacondarwin @AndrewKushnir
test(ivy): i18n - reenable ivy i18n runtime integration test (#33462)
d1246a1 
PR Close #33462
matsko pushed a commit to matsko/angular that referenced this pull request Oct 30, 2019
@petebacondarwin @matsko
test(ivy): i18n - add XMB e2e integration test (angular#33462)
f95e636 
This integration test now does a full e2e test of:

* extraction -> build -> translation - serve

for both XLIFF 1.2 and XMB formats.

Resolves angular#33444 (comment)

PR Close angular#33462
matsko pushed a commit to matsko/angular that referenced this pull request Oct 30, 2019
@petebacondarwin @matsko
test(ivy): i18n - reenable ivy i18n runtime integration test (angular…
1097de4 
…#33462)

PR Close angular#33462
@petebacondarwin petebacondarwin deleted the i18n-xmb-e2e branch October 30, 2019 21:24
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@petebacondarwin @mohaxspb
test(ivy): i18n - add XMB e2e integration test (angular#33462)
ce13ed1 
This integration test now does a full e2e test of:

* extraction -> build -> translation - serve

for both XLIFF 1.2 and XMB formats.

Resolves angular#33444 (comment)

PR Close angular#33462
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@petebacondarwin @mohaxspb
test(ivy): i18n - reenable ivy i18n runtime integration test (angular…
c5f97d1 
…#33462)

PR Close angular#33462
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@petebacondarwin @mohaxspb
test(ivy): i18n - add XMB e2e integration test (angular#33462)
08c0b38 
This integration test now does a full e2e test of:

* extraction -> build -> translation - serve

for both XLIFF 1.2 and XMB formats.

Resolves angular#33444 (comment)

PR Close angular#33462
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@petebacondarwin @mohaxspb
test(ivy): i18n - reenable ivy i18n runtime integration test (angular…
d5f7744 
…#33462)

PR Close angular#33462
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: i18n cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petebacondarwin @josephperrott @AndrewKushnir @googlebot