Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): undecorated-classes-with-di migration should report config errors #33567

Closed
wants to merge 1 commit into from
Closed

fix(core): undecorated-classes-with-di migration should report config errors #33567

wants to merge 1 commit into from

Commits on Nov 4, 2019

  1. fix(core): undecorated-classes-with-di migration should report config… 

    … errors

Currently TypeScript projects with an invalid tsconfig configuration,
cause the undecorated-classes-with-di migration to throw. Instead we
should gracefully exit the migration (like we do for syntactical
diagnostics), but report that there are configuration issues.

This issue surfaced when testing this migration in combination
with the Angular CLI migrations. One of the CLI migrations currently
causes invalid tsconfig files which then cause this issue in the
undecorated-classes-with-di migration.
    @devversion
    devversion committed Nov 4, 2019
    Copy the full SHA
    6a3593f View commit details
    Browse the repository at this point in the history