-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(service-worker): allow creating post api requests after cache failure #33930
fix(service-worker): allow creating post api requests after cache failure #33930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, @apocalyp0sys ❤️
(Nice commit message, btw 👍)
a8820d8
to
528477b
Compare
This comment has been minimized.
This comment has been minimized.
@apocalyp0sys please update the payload size amount so we can merge this. |
Enable to create mocks for mutating http requests in tests to check more scenarios.
…lure Before creating a mutating http request, service-worker invalidates lru cache entry and writes to cache storage. Therefore, cache storage failure can prevent making post requests. Fix this by catching and logging cache error, add a test case. Fixes angular#33793
528477b
to
809e9da
Compare
@matsko rebased onto master |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Before creating a mutating http request, service-worker invalidates lru cache entry and writes to cache storage. Therefore, cache storage failure can prevent making post requests.
Issue Number: #33793
What is the new behavior?
Cache storage error is catched and logged when trying to update lru cache table.
Does this PR introduce a breaking change?