-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use more descriptive names for published build artifacts #33957
Conversation
In efbbae5, the `publish_packages_as_artifacts` CircleCI job was created to publish the build artifacts of PR builds on CI. In a8f4f14, its scope was expanded to also publish build artifacts on non-PR builds. The published artifacts names are constructed based on the PR number (e.g. include `-pr12345-`), so on non-PR builds the names do not reflect the source branch (instead, they include `-prfalse-`). This commit fixes this by using the current branch name. For example, artifact names for the `master` or `9.0.x` branch will include `-master-` and `-9.0.x-` respectively (instead of `-prfalse-`). (NOTE: For PRs, where branch name is `pull/12345`, the branch name is transformed to `pr12345`.)
merge-assistance: The integration_test failure is unrelated. (Will be fixed by #33955.) |
removing the merge-assistance label, as the caretaker can't merge PRs when CI is failing. @gkalpak is right the issue has been fixed upstream, but the caretaker can't know this for sure. rebasing the PR or restarting the CI (the entire workflow, not just failed job - this causes an automatic rebase on CI), should green up this PR |
In efbbae5, the `publish_packages_as_artifacts` CircleCI job was created to publish the build artifacts of PR builds on CI. In a8f4f14, its scope was expanded to also publish build artifacts on non-PR builds. The published artifacts names are constructed based on the PR number (e.g. include `-pr12345-`), so on non-PR builds the names do not reflect the source branch (instead, they include `-prfalse-`). This commit fixes this by using the current branch name. For example, artifact names for the `master` or `9.0.x` branch will include `-master-` and `-9.0.x-` respectively (instead of `-prfalse-`). (NOTE: For PRs, where branch name is `pull/12345`, the branch name is transformed to `pr12345`.) PR Close #33957
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In efbbae5, the
publish_packages_as_artifacts
CircleCI job was created to publish the build artifacts of PR builds on CI. In a8f4f14, its scope was expanded to also publish build artifacts on non-PR builds.The published artifacts names are constructed based on the PR number (e.g. include
-pr12345-
), so on non-PR builds the names do not reflect the source branch (instead, they include-prfalse-
).This commit fixes this by using the current branch name. For example, artifact names for the
master
or9.0.x
branch will include-master-
and-9.0.x-
respectively (instead of-prfalse-
).(NOTE: For PRs, where branch name is
pull/12345
, the branch name is transformed topr12345
.)