fix: work around 'noImplicityAny' incompatibility due to ts3.7 update #34798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
force-pushed
the
test/fix-typings-ts-flags
branch
from
08cfaa9
to
dc5e61a
Compare
IgorMinar
force-pushed
the
test/fix-typings-ts-flags
branch
from
dc5e61a
to
3030685
Compare
IgorMinar
changed the title
|
You can preview 3030685 at https://pr34798-3030685.ngbuilds.io/. |
we should try to reuse as many dependencies as we can from the top level node_modules.
previously they didn't which was a bug/oversight.
skipLibCheck=false is currently the default (in tsc 3.7.4) but it wouldn't be shocking if the default changed in the future because skipLibCheck=true makes more sense in almost all scenarios. So just to be defensive and explicit, I'm setting the flag to false even though it's the current default.
IgorMinar
force-pushed
the
test/fix-typings-ts-flags
branch
from
3030685
to
5da86df
Compare
IgorMinar
added
area: build & ci
|
You can preview 5da86df at https://pr34798-5da86df.ngbuilds.io/. |
IgorMinar
added
target: patch
Typescript 3.7 now emits d.ts files for getters differently than prior versions, and there seems to be a bug in how it strips private types without replacing them with explicit 'any' type. This then leads to compilation failures in projects compiled against our packages that don't have skipLibCheck turned on but do have strict or noImplicitAny check on. I'm working around this by marking the affected getters as @internal and adding a test to prevent future regressions. I believe this is a TypeScript bug, and I filed a bug report: microsoft/TypeScript#36216
IgorMinar
force-pushed
the
test/fix-typings-ts-flags
branch
from
5da86df
to
355ecdf
Compare
|
merge-assistance: global approval |
|
You can preview 355ecdf at https://pr34798-355ecdf.ngbuilds.io/. |
matsko
pushed a commit
that referenced
this pull request
Jan 16, 2020
previously they didn't which was a bug/oversight. PR Close #34798
matsko
pushed a commit
that referenced
this pull request
Jan 16, 2020
skipLibCheck=false is currently the default (in tsc 3.7.4) but it wouldn't be shocking if the default changed in the future because skipLibCheck=true makes more sense in almost all scenarios. So just to be defensive and explicit, I'm setting the flag to false even though it's the current default. PR Close #34798
matsko
pushed a commit
that referenced
this pull request
Jan 16, 2020
…#34798) Typescript 3.7 now emits d.ts files for getters differently than prior versions, and there seems to be a bug in how it strips private types without replacing them with explicit 'any' type. This then leads to compilation failures in projects compiled against our packages that don't have skipLibCheck turned on but do have strict or noImplicitAny check on. I'm working around this by marking the affected getters as @internal and adding a test to prevent future regressions. I believe this is a TypeScript bug, and I filed a bug report: microsoft/TypeScript#36216 PR Close #34798
matsko
pushed a commit
that referenced
this pull request
Jan 16, 2020
) we should try to reuse as many dependencies as we can from the top level node_modules. PR Close #34798
matsko
pushed a commit
that referenced
this pull request
Jan 16, 2020
previously they didn't which was a bug/oversight. PR Close #34798
matsko
pushed a commit
that referenced
this pull request
Jan 16, 2020
skipLibCheck=false is currently the default (in tsc 3.7.4) but it wouldn't be shocking if the default changed in the future because skipLibCheck=true makes more sense in almost all scenarios. So just to be defensive and explicit, I'm setting the flag to false even though it's the current default. PR Close #34798
matsko
pushed a commit
that referenced
this pull request
Jan 16, 2020
…#34798) Typescript 3.7 now emits d.ts files for getters differently than prior versions, and there seems to be a bug in how it strips private types without replacing them with explicit 'any' type. This then leads to compilation failures in projects compiled against our packages that don't have skipLibCheck turned on but do have strict or noImplicitAny check on. I'm working around this by marking the affected getters as @internal and adding a test to prevent future regressions. I believe this is a TypeScript bug, and I filed a bug report: microsoft/TypeScript#36216 PR Close #34798
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 17, 2020
…7 update (angular#34798) This reverts commit 63c9c2d.
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 17, 2020
…ular#34798) This reverts commit f2a5454.
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 17, 2020
…ngular#34798) This reverts commit 7dc74de.
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 17, 2020
…son (angular#34798) This reverts commit 39ab72e.
|
Upstream fix in TypeScript has been backported to 3.6.5: https://github.com/microsoft/TypeScript/releases/tag/v3.6.5 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 3.7 now emits d.ts files for getters differently than prior versions,
and there seems to be a bug in how it strips private types without replacing them
with explicit 'any' type. This then leads to compilation failures in projects compiled
against our packages that don't have skipLibCheck turned on but do have strict or
noImplicitAny check on.
I'm working around this by marking the affected getters as @internal and
adding a test to prevent future regressions.
Typescript bug report: microsoft/TypeScript#36216