Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): If users are using the Alt key when clicking the router links, prioritize browser’s default behavior #38375

Closed
wants to merge 1 commit into from

Commits on Sep 2, 2020

  1. fix(router): If users are using the Alt key when clicking the router …

    …links, prioritize browser’s default behavior
    
    In most browsers, clicking links with the Alt key has a special behavior, for example, Chrome
    downloads the target resource. As with other modifier keys, the router should stop the original
    navigation to avoid preventing the browser’s default behavior.
    
    When users click a link while holding the Alt key together, the browsers behave as follows.
    
    Windows 10:
    
    | Browser    | Behavior                                    |
    |:-----------|:--------------------------------------------|
    | Chrome 84  | Download the target resource                |
    | Firefox 79 | Prevent navigation and therefore do nothing |
    | Edge 84    | Download the target resource                |
    | IE 11      | No impact                                   |
    
    macOS Catalina:
    
    | Browser    | Behavior                                    |
    |:-----------|:--------------------------------------------|
    | Chrome 84  | Download the target resource                |
    | Firefox 79 | Prevent navigation and therefore do nothing |
    | Safari 13  | Download the target resource                |
    yuheiy authored and atscott committed Sep 2, 2020
    Copy the full SHA
    f94fced View commit details
    Browse the repository at this point in the history