Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): reset tView between tests in Ivy TestBed #38659

Closed

Commits on Sep 1, 2020

  1. fix(core): reset tView between tests in Ivy TestBed

    `tView` that is stored on a component def contains information about directives and pipes
    that are available in the scope of this component. Patching component scope causes `tView` to be
    updated. Prior to this commit, the `tView` information was not restored/reset in case component
    class is not declared in the `declarations` field while calling `TestBed.configureTestingModule`,
    thus causing `tView` to be reused between tests (thus preserving scopes information between tests).
    This commit updates TestBed logic to preserve `tView` value before applying scope changes and
    reset it back to the previous state between tests.
    
    Closes angular#38600.
    AndrewKushnir committed Sep 1, 2020
    Copy the full SHA
    aef91ea View commit details
    Browse the repository at this point in the history