Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localize): install @angular/localize in devDependencies by default #38680

Closed

Commits on Sep 2, 2020

  1. fix(localize): install @angular/localize in devDependencies by de…

    …fault
    
    Previously this package was installed in the default `dependencies` section
    of `package.json`, but this meant that its own dependencies are treated as
    dependencies of the main project: Babel, for example.
    
    Generally, $localize` is not used at runtime - it is compiled out by the
    translation tooling, so there is no need for it to be a full dependency.
    In fact, even if it is used at runtime, the package itself is only used
    at dev-time since the runtime bits will be bundled into a distributable.
    So putting this package in `devDependencies` would only prevent libraries
    from bringing the package into application projects that used them. This
    is probably good in itself, since it should be up to the downstream project
    to decide if it wants to include `@angular/localize` at runtime.
    
    This commit changes the default location of the package to be the
    `devDependencies` section, but gives an option `useAtRuntime` to choose
    otherwise.
    
    Fixes angular#38329
    petebacondarwin committed Sep 2, 2020
    Copy the full SHA
    7bae350 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    4ad5b3b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Copy the full SHA
    d973d04 View commit details
    Browse the repository at this point in the history